This changes the wrong color - users were not expecting to first set the Main background in these settings.

Solutions discussed in usability wrap-up:

"Reorder colorable regions in order of typical visual appearance.
Example:
- Header Top
- Header Bottom
- Main Background
- Links
- …"

Comments

Jeff Burnz’s picture

Component: color.module » Bartik theme

Themes define the order of the list, moving to Bartik.

tim.plunkett’s picture

sub

johnalbin’s picture

Issue tags: +Needs backport to D7

This is actually small enough a change that we could backport it to D7. No string changes, just re-ordering a form.

tim.plunkett’s picture

Status: Active » Needs review
StatusFileSize
new3.2 KB
aspilicious’s picture

I think this is ok :). Can use another pair of eyes but this looks good to me.

Bojhan’s picture

Can we get a screenie?

tim.plunkett’s picture

StatusFileSize
new82.1 KB

drupal-1164792.png

Bojhan’s picture

Status: Needs review » Reviewed & tested by the community

Looks good, RTBC it is :)

webchick’s picture

Issue tags: -Needs backport to D7

We can't break strings in 7.x, nor can we invalidate screenshots/documentation, so I don't think we can get this fix into 7.x.

tim.plunkett’s picture

This one doesn't break any strings, that's in #1164828: Color labels are not intuitive when searching for the keyword “background”. But if reordering them is a big enough discrepancy for screenshots, I understand.

Jeff Burnz’s picture

Good to go, very simple reordering of the array items.

dries’s picture

Committed to 8.x. Moving to 7.x. I think this could be back-ported; as far as I can see it doesn't break any strings. Seems like a fairly minor UI change.

aspilicious’s picture

Version: 8.x-dev » 7.x-dev

Moving back to 7.X

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Fair enough. I was getting this issue confused with #1164828: Color labels are not intuitive when searching for the keyword “background” and being a little too defensive of book authors. :)

Committed to 7.x, too.

dcmistry’s picture

Yayy! Yayy! Yayy!

Automatically closed -- issue fixed for 2 weeks with no activity.