Let's use hook_hook_info() to offload any RDF hooks into modulename.rdf.inc.

CommentFileSizeAuthor
#1 1166140-rdf-hook-info.patch17.92 KBdave reid

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Needs review
Issue tags: +hook separation
StatusFileSize
new 1166140-rdf-hook-info.patch17.92 KB
scor’s picture

scor commented

That's a good idea for the implementations of hook_rdf_mapping(), this code is actually rarely used as it is cached in entity_info.

rdf_rdf_namespaces() on the other hand is called on every single page load, and I wonder if moving it to a separate file is worth the extra file load.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Postponed

The RDF mapping API may change as a result of the work in #1778226: [META] Fix RDF module.

Anonymous’s picture

Anonymous (not verified) commented

Also, this issue is related #1373884: [meta] Core does not use hook_hook_info()

Anonymous’s picture

Anonymous (not verified) commented

The only remaining rdf hook is hook_rdf_namespaces, which will be removed with #1778410: Throw exception when RDF namespaces collide. Once that is in, this can be closed.

mgifford’s picture

mgifford
he/him
Primary language English
commented
Issue summary: View changes

@linclark - Can we close this issue now?

scor’s picture

scor commented
Status: Postponed » Closed (won't fix)

I don't think it's worth it or needed given that there is only hook_rdf_namespaces() left, and that most modules won't even have to implement this hook. The implementation in rdf.module will also go down in size once we remove all the other namespaces.