A relatively frequently reported problem in the support system is about wrongly entered API keys.

We can do a bit better on ensuring proper keys.

This patch is 1) missing tests, and 2) most likely won't pass existing tests, since some tests are trying to save completely invalid values.

CommentFileSizeAuthor
#9 mollom.admin-key-validate.9.patch3.65 KBsun
#3 mollom.admin-key-validate.3.patch3.66 KBsun
mollom.admin-key-validate.0.patch1.7 KBsun

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, mollom.admin-key-validate.0.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Needs review
StatusFileSize
new mollom.admin-key-validate.3.patch3.66 KB
sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs backport to D6
dries’s picture

dries commented
Status: Reviewed & tested by the community » Patch (to be ported)

Committed to 'master'. Needs to be ported to the other branches.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
Status: Patch (to be ported) » Needs review

Applies cleanly for me, so let's see what the testbot thinks.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Issue tags: -Needs backport to D6

#3: mollom.admin-key-validate.3.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Needs backport to D6

The last submitted patch, mollom.admin-key-validate.3.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Needs review
StatusFileSize
new mollom.admin-key-validate.9.patch3.65 KB

Odd. Apparently it does not apply for the bot.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Fixed

Committed to 6.x-1.x.

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit bd10de4 on master, fai6, 8.x-2.x, fbajs, actions by Dries: 
    - Patch #1166494 by sun: ensure that API keys don't contain leading/...

  • Commit bd10de4 on master, fai6, 8.x-2.x, fbajs, actions by Dries: 
    - Patch #1166494 by sun: ensure that API keys don't contain leading/...