152 drupal_alter('rest_server_exectue_errors', $errors, $controller, $arguments);

Should this be "rest_server_execute_errors"? This hook does not seem to be documented either.

Patches incoming in a few minutes when I get the issue #.

CommentFileSizeAuthor
#1 1167244-Start-on-documentation-of-hoo.patch1.11 KBmradcliffe
#1 1167244-Typo-noticed-in-RESTServer.patch1.03 KBmradcliffe

Comments

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new 1167244-Typo-noticed-in-RESTServer.patch1.03 KB
new 1167244-Start-on-documentation-of-hoo.patch1.11 KB

I don't know if that documentation patch is correct, but the typo one is good.

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented

I also think there is an issue with commit 4a35edd8337702540d24d2f3bd07b4751f92649e and nesting the exceptions caught, but there aren't any RESTServer tests to test this. That's another issue, and I guess I'll need to write a test for it to see if those exceptions are correctly returning 401 error codes on a vanilla services endpoint. That would be in a separate issue.

Edit: sorry, I was incorrect. I am still learning all the code within services.
Edit 2: I can't reproduce the issue in this comment. Ignore.

kylebrowning’s picture

kylebrowning commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.