When many skins are enabled, the UI for applying them becomes a bit unwieldy. A small improvement would be to permit collapsible fieldsets for skinr groups. Small patch attached.

Sample usage:

/**
 * Implements hook_skinr_group_PLUGIN_info().
 */
function fusion_core_skinr_group_core_info() {
  $groups['menus'] = array(
    'title' => t('Menus'),
    'description' => t('Menu and navigation styles.'),
    'collapsible' => TRUE,
    'collapsed' => TRUE,    
  );
  return $groups;
}

The patch adds checks for two new boolean properties in the group definition: collapsible and collapsed.

CommentFileSizeAuthor
#3 skinr-1172454-vertical-tab-groups.patch7.72 KBaquariumtap
skinr-allow-collapsable-groups.patch1.03 KBaquariumtap

Comments

moonray’s picture

moonray commented

This was possible in the D6 version. Actually, the reason we removed this is that we were planning to implement vertical tabs, but we haven't gotten back to UI improvements yet due to dealing with the back-end code.

Jacine can probably add some details to this.

aquariumtap’s picture

aquariumtap commented

I'm looking into vertical tabs.

Right now the form structure has each theme's skinr settings inside of a collapsible fieldset. Only the active/default theme is expanded, which is a great UI feature. None of that should change.

The vertical tabs would go inside of those fieldsets, and each skinr group would be a tab. (If no group is indicated in the skin's definition, it defaults to the General group -- that's perfect.)

In order to implement this, the form array has to become one level deeper. Currently all the data on a theme's skins is saved here:

$form['skinr_settings'][$module . '_group'][$theme->name]

That would need to change to something like this, where 'groups' contains #type=>'vertical_tabs':

$form['skinr_settings'][$module . '_group'][$theme->name]['groups']

That affects a few areas (the UI, the data handler and the relevant tests). Before proposing a patch, am I thinking along the same lines as y'all? I saw Jacine's awesome sweaver-style comp for a front end overlay, but this might be a quicker UI improvement until that begins making headway.

aquariumtap’s picture

aquariumtap commented
StatusFileSize
new skinr-1172454-vertical-tab-groups.patch7.72 KB

Patch attached for vertical tabs

moonray’s picture

moonray commented
Status: Needs review » Closed (duplicate)

This is actually a dup of #952610: Vertical tabs integration.