HTML5 shiv issues with IE6/7/8

Hmm, Make sense,

Maybe we should also include the innershiv js.

I think now that there's a html5 d8 initiative we should pretty much back-port everything to this module.

Also this might be a good d8 issue.

I might try and make a patch for html5 base to do this for d7. Or should this code live in html5tools? Not totally clear where the between them is on this.

And depending on the outcome of #1077878: Add HTML5shiv to core there may need to be a d8 core issue for it as well.

Since we use JQuery in Drupal, we could safely remove the second parameter and return childNodes directly.
The WTFPL license is problematic, we should see if the author is likely to change the license if we use this technique.
A jQuery method that behaves like load() is also mentioned : https://gist.github.com/735829.

You've gotta enjoy the irony if there are indeed licensing issues. Does the WTFPL not mean we can just include it without attribution and under whatever license modules fall under?

"If you do not like the license terms, just relicense [sic] the work under another license." ...taken from the wtfpl license page

We could use that plugin. We'll just need to remove the license

Also tools seems more appropriate that base.

Hehe, did not take the time to check the WTFPL license terms :)

There seems to be a more advanced version of the innerShiv, which also strips script tags, fixes tables, handles XHTML properly and stuff...

the newer version also bails early on when it detects the browser to be able to render HTML5 elements created outside of the active DOM.

Attached patch assumes patch #82 in #1077878: Add HTML5shiv to core went in

just found out we are using prefixed patches nowadays, my apologies

seutje: If you add the monkey patch into html5.js, you need to ensure that html5.js it loaded after ajax.js:

  $libraries['html5shim'] = array(
    'title' => 'html5shim',
    'website' => 'http://html5shim.googlecode.com/svn/trunk/html5.js',
    'version' => 'r10',
    'js' => array(
      'misc/html5.js' => array('group' => JS_LIBRARY, 'weight' => 3),
    ),
    'dependencies' => array(
      array('system', 'drupal.ajax'),
    ),
  );

We shouldn't be patching the html5.js file being that this is for d7, we should include our own html5.js in tools instead.

Mind you tools is for 6 and 7. Not so much for 8 ;)

oh, my bad

dont forget if we cinlude our own html5.js we will likely need to make sure the core version isnt also loaded.

We don't really need to include a html5_tools specific js.

The scripts each have their own names they should stay that way.

We just need to provide the hook_libraries for the scripts.

Also if the html5.js makes it into core it'll be sometime before it gets in 7. Also I doubt there actually be a specific file name html5.js I think thats bad naming and we shouldn't name it that neither ;)

So, instead of monkey patching, I patched my local ajax.js to have the same fix by adding:

    response.data = innerShiv(response.data, false);

at the very top of Drupal.ajax.prototype.commands.insert, however, when using innerShiv this broke the AJAX framework when it attempts to insert scripts, because innerShiv strips out

This is possible without hacking core.

@inolen: https://github.com/jdbartlett/innershiv/issues/4#issuecomment-1051825

Ok, so the shiv is in this module for 7.x now we need to do the innershiv. I'm not totally sure on this one.

Any recommendations?

Ok, this is now fixed. I just monkey patch it as @seutje did.

So now the shiv and the innershiv are easily accesible in this module.

Thanks all.