Depending on the parent environment and network configuration, like Amazon EC2, VirtualBox etc, the IP is not always correctly printed in the vhost file, while it should fall back to the wildcard * in this case, like it is used in the Apache version by default for non-SSL vhosts.

Comments

omega8cc’s picture

omega8cc CreditAttribution: omega8cc commented
Status: Active » Needs review

This commit fixes the issue: http://drupalcode.org/sandbox/omega8cc/1111100.git/commit/f8b91b7

omega8cc’s picture

omega8cc CreditAttribution: omega8cc commented

We have to modify the server config template again to avoid issue with no longer working default vhost, as any vhost with defined IP instead of wildcard will take precedence over default.

For the same reason we can't switch now to use wildcard only everywhere, because it could break configuration on upgrade, until all vhosts/sites are re-verified.

The fix: http://drupalcode.org/sandbox/omega8cc/1111100.git/commit/da0afdf

anarcat’s picture

anarcat CreditAttribution: anarcat commented
Status: Needs review » Fixed

Seems reasonable, pushed to both 2.x and 1.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit f03b8e1 on 7.x-2.x, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-subdir-multiserver, 6.x-2.x-backports, dev-helmo-3.x authored by omega8cc, committed by anarcat: 
    Issue #1183500 - Nginx config should fall back to standard wildcard if $...
  • Commit 2a42a90 on 7.x-2.x, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-subdir-multiserver, 6.x-2.x-backports, dev-helmo-3.x authored by omega8cc, committed by anarcat:
    Issue #1183500 - default Nginx vhost should still use IP if available or...
  • Commit 29df3ea on 6.x-1.x, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-subdir-multiserver, 6.x-2.x-backports, dev-helmo-3.x authored by omega8cc, committed by anarcat:
    Issue #1183500 - Nginx config should fall back to standard wildcard if $...
  • Commit 4100ae7 on 6.x-1.x, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-subdir-multiserver, 6.x-2.x-backports, dev-helmo-3.x authored by omega8cc, committed by anarcat:
    Issue #1183500 - default Nginx vhost should still use IP if available or...