Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The <q> tag needs some formatting. It looks exactly like the rest of the paragraph, like this: this is a quote
. Which makes it kind of useless.
http://www.w3schools.com/tags/tryit.asp?filename=tryhtml_q has it actually shown in quote marks. drupal.org has q { quotes: none; }
, which, without some kind of other formatting, makes the tag pointless. I reckon removing that css for the q tag would be a good idea.
Comment | File | Size | Author |
---|---|---|---|
#8 | q-formatting-1195950-8.patch | 514 bytes | mgifford |
#4 | q-formatting-1195950.patch | 431 bytes | mgifford |
Comments
Comment #1
lisarex CreditAttribution: lisarex commentedMoving this to the Bluecheese (theme) project
Comment #2
naught101 CreditAttribution: naught101 commentedAh, thanks. I knew this was in the wrong spot, but didn't know where the right spot was...
Comment #3
mgiffordCurrently we're using:
So this does look like it is still a problem. Let me
The use of
<q>
vs<blockquote>
needs to be considered:This is still part of html5 http://www.w3schools.com/tags/tag_q.asp
Hasn't been managed well by browsers http://alistapart.com/article/qtag
Has lots of possible fixes
But we should deal with this issue or close it.
Comment #4
mgiffordThis looks better to me.
Comment #5
drummcss changes should not be made directly, they must be made to .scss files in the sass directory and compiled. See https://drupal.org/node/1953368.
Comment #6
mgiffordOk, I appreciate that. But is css/styles.css built somewhere else?
[mgifford@devwww partials]$ pwd
/var/www/dev/search_api-drupal.redesign.devdrupal.org/htdocs/sites/all/themes/bluecheese/sass/partials
[mgifford@devwww partials]$ grep -ir "q" *
That should tell me where styling for
<q>
is in the sass files, right?I suppose I could add something different to the bottom of common/_basic-elements.scss
However my patch was simply to remove this existing css:
q:before, q:after, blockquote:before, blockquote:after
Comment #7
tvn CreditAttribution: tvn commentedcss/styles.css is built from the sass partials only, however in the partials/utilities/_utilities.scss you can see that we also import various resets, which come before our own sass partials. Such as: @import 'compass/reset';.
The css you mentioned comes from there and isn't in our sass files, you can add something to _basic_elements to override it indeed.
Please also always provide url where we can see the patch in action if there is any visual change. Thanks!
Comment #8
mgiffordI don't think I have permission to compile the CSS.
[mgifford@devwww bluecheese]$ compass compile sass/partials/common/_basic-elements.scss
Errno::EACCES on line ["25"] of /usr/local/rvm/gems/ruby-1.9.3-p429/gems/sass-3.2.9/lib/sass/cache_stores/filesystem.rb: Permission denied - /var/www/dev/search_api-drupal.redesign.devdrupal.org/htdocs/sites/all/themes/bluecheese/.sass-cache/115e87dd1ccd9c60512856eb8adefede3aade0cc/_basic-elements.scssc
Run with --trace to see the full backtrace
Since I'm having to assert rather than simply remove code I'm going with examples from:
http://css-tricks.com/almanac/properties/q/quotes/
https://developer.mozilla.org/en-US/docs/Web/CSS/quotes
Comment #9
drummCleaned up, committed, and deployed: