The &ltq> tag needs some formatting. It looks exactly like the rest of the paragraph, like this: this is a quote. Which makes it kind of useless.

http://www.w3schools.com/tags/tryit.asp?filename=tryhtml_q has it actually shown in quote marks. drupal.org has q { quotes: none; }, which, without some kind of other formatting, makes the tag pointless. I reckon removing that css for the q tag would be a good idea.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

lisarex’s picture

Project: » Bluecheese
Component: Everything Else » User interface
Category: bug » feature

Moving this to the Bluecheese (theme) project

naught101’s picture

Ah, thanks. I knew this was in the wrong spot, but didn't know where the right spot was...

mgifford’s picture

Currently we're using:

q, blockquote {
  quotes: none;
}
q:before, q:after, blockquote:before, blockquote:after {
  content: "";
  content: none;
}

So this does look like it is still a problem. Let me put this in quotes.

The use of <q> vs <blockquote> needs to be considered:

This is in blockquotes

This is still part of html5 http://www.w3schools.com/tags/tag_q.asp

Hasn't been managed well by browsers http://alistapart.com/article/qtag

Has lots of possible fixes

But we should deal with this issue or close it.

mgifford’s picture

Issue summary: View changes
Status: Active » Needs review
FileSize
431 bytes

This looks better to me.

drumm’s picture

Status: Needs review » Needs work

css changes should not be made directly, they must be made to .scss files in the sass directory and compiled. See https://drupal.org/node/1953368.

mgifford’s picture

Ok, I appreciate that. But is css/styles.css built somewhere else?

[mgifford@devwww partials]$ pwd
/var/www/dev/search_api-drupal.redesign.devdrupal.org/htdocs/sites/all/themes/bluecheese/sass/partials
[mgifford@devwww partials]$ grep -ir "q" *

That should tell me where styling for <q> is in the sass files, right?

I suppose I could add something different to the bottom of common/_basic-elements.scss

However my patch was simply to remove this existing css:
q:before, q:after, blockquote:before, blockquote:after

tvn’s picture

css/styles.css is built from the sass partials only, however in the partials/utilities/_utilities.scss you can see that we also import various resets, which come before our own sass partials. Such as: @import 'compass/reset';.
The css you mentioned comes from there and isn't in our sass files, you can add something to _basic_elements to override it indeed.

Please also always provide url where we can see the patch in action if there is any visual change. Thanks!

mgifford’s picture

Status: Needs work » Needs review
FileSize
514 bytes

I don't think I have permission to compile the CSS.

[mgifford@devwww bluecheese]$ compass compile sass/partials/common/_basic-elements.scss
Errno::EACCES on line ["25"] of /usr/local/rvm/gems/ruby-1.9.3-p429/gems/sass-3.2.9/lib/sass/cache_stores/filesystem.rb: Permission denied - /var/www/dev/search_api-drupal.redesign.devdrupal.org/htdocs/sites/all/themes/bluecheese/.sass-cache/115e87dd1ccd9c60512856eb8adefede3aade0cc/_basic-elements.scssc
Run with --trace to see the full backtrace

Since I'm having to assert rather than simply remove code I'm going with examples from:
http://css-tricks.com/almanac/properties/q/quotes/
https://developer.mozilla.org/en-US/docs/Web/CSS/quotes

drumm’s picture

Version: » 7.x-1.x-dev
Assigned: Unassigned » drumm
Status: Needs review » Fixed

Cleaned up, committed, and deployed: example

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.