We had some issues with the cache storing the full URL after a failed attempt at shortening. I added some code to doublecheck that the cached data hasn't expired yet, ignoring it if it has. I also added a system variable for changing the duration of a caching a full url and an admin page section for changing that value. Patch to follow in comments.

CommentFileSizeAuthor
#1 full_url_cache_duration-1215550-1.patch1.77 KBjsagotsky

Comments

jsagotsky’s picture

jsagotsky commented
StatusFileSize
new full_url_cache_duration-1215550-1.patch1.77 KB
icecreamyou’s picture

icecreamyou commented
Category: bug » feature
Priority: Normal » Minor
Status: Active » Needs review

Cool. Looks good. I'll test and commit as soon as I get a chance.

icecreamyou’s picture

icecreamyou commented
Version: 6.x-1.11 » 7.x-1.x-dev
Status: Needs review » Patch (to be ported)

There were a couple of important details the patch left out -- fixed them and committed to dev. Now the patch needs to be ported/applied to the D7 branch (the main difference is that REQUEST_TIME should be used instead of time()).

icecreamyou’s picture

icecreamyou commented
Status: Patch (to be ported) » Fixed

Committed fix to 7.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.