=== modified file 'tagadelic.module'
--- tagadelic.module    2007-02-23 08:24:13 +0000
+++ tagadelic.module    2007-02-23 08:24:47 +0000
@@ -316,7 +316,7 @@
   if ($op == 'view') {
     if ($voc = taxonomy_get_vocabulary($delta)) {
       $blocks['subject'] = variable_get('tagadelic_block_title_'. $delta, t('tags in @voc', array('@voc' => $voc->name)));
-      $tags = tagadelic_get_weighted_tags(array($voc->vid),6, variable_get('tagadelic_block_tags_'. $delta, 12));
+      $tags = tagadelic_get_weighted_tags(array($voc->vid), variable_get('tagadelic_levels', 6), variable_get('tagadelic_block_tags_'. $delta, 12));
       $tags = tagadelic_sort_tags($tags);
       $blocks['content'] = theme('tagadelic_weighted', $tags);//return a chunk of 12 tags
     }
CommentFileSizeAuthor
#5 tagadelic.module.patch820 bytesextrabigmehdi

Comments

Bèr Kessels’s picture

Bèr Kessels commented
Status: Needs review » Needs work

please attach a real patch.

ardee-1’s picture

ardee-1 commented

For what it's worth, I made the indicated change in 4.7.x, and it seems to work.

extrabigmehdi’s picture

extrabigmehdi commented

hi Bèr Kessels,
the issue still exists with drupal 5.1, and the patch suggested by ardee works fine.
I don't know what you call a "real patch" and anyway this looks like a pain to use the diff tool under windows (well, when I read this thread)

What I've done, is reading the patch files, and applied modifications manually.
This is pretty simple:
Inside function tagadelic_block,
I replace the hardcoded 6, by variable_get('tagadelic_levels', 6)
and then everything work fine.

Bèr Kessels’s picture

Bèr Kessels commented

please look at http://drupal.org/diffandpatch

extrabigmehdi’s picture

extrabigmehdi commented
StatusFileSize
new tagadelic.module.patch820 bytes

I've just generated a patch file using WinMerge .
I hope this one is of your taste (file in attachement).

Bèr Kessels’s picture

Bèr Kessels commented
Status: Needs work » Fixed

Fixed in 5.x HEAD.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.