Rules Form API - Extracting values

>+ if (isset($value_state['provides'])) {

$value_state isn't a fitting variable name ;) Let's just use $values, or $form_values.

> // Enable AJAX once #756762 is fixed.
- // '#ajax' => rules_ui_form_default_ajax('none'),
+ '#ajax'
Does that work? IF yes, remove the comment too.

>Returns the right form values array from the $form_state.
Let's shortly describe that this is necessary if form is embedded somewhere.

Else the patch looks good to me.

   /**
+   * Returns the form values for the given form, possible being only a part of the whole form.
+   *
+   * In case the form is embedded somewhere, this function figures out the
+   * location of its form values and returns them for further use.
+   *
+   * @param $form
+   *   A form array, or an array of form elements to get the value for.
+   * @param $form_state
+   *   The form state as usual.
+   */

I fixed the comment to be like that.

Also, I've done some improvements like directly passing $form['settings'] and fixing the function when called during $form generation + I fixed a validation problem.

Committed it, thanks.