This project needs an official Drupal 7 release and a maintainer. I am not itching to do it, but this is a pretty simple module that a lot of people use. If necessary I am willing.

I have contacted skilip who ported the module and have not heard back yet. We also need to hear from johnfyoung and challa.kamel (the previous maintainers).

Comments

pfrenssen’s picture

pfrenssen
Location Sofia
commented

I have looked through the code and am testing the module now. The basic functionality is there and everything seems to work fine. If I encounter any problems during testing I'll file an issue.

jamesbenison’s picture

jamesbenison commented

Challa got back to me and encouraged me to take over the old project. Problem is that he did not provide maintainer permissions. After trying to re-contact him a couple weeks ago I have not yet heard back. It may be time to take this to a drupal admin.

And thanks for testing.

pfrenssen’s picture

pfrenssen
Location Sofia
commented

I have tested the module and it works very well. I am using it in production now.

Anonymous’s picture

Anonymous (not verified) commented

-

pfrenssen’s picture

pfrenssen
Location Sofia
commented

Months have passed since you contacted the original maintainer. If you don't hear anything anymore, maybe you can initiate the abandoned projects procedure?

jamesbenison’s picture

jamesbenison commented

Actually the maintainer asked me to take over the orginal project. But he didn't grant me maintainer permissions and I haven't heard back since.

I'm worried about stretching myself too thin. So if anyone is interested in maintaing this or even co-maintaining it I'll promote it.

pfrenssen’s picture

pfrenssen
Location Sofia
commented

I am willing to help with this. I have started going through the issue queue to see what needs to be done and I have created a sandbox that will hold both the original 6.x and your 7.x branch together. There needs to be some work done on 7.x to incorporate the latest changes in 6.x which have accidentally been committed to the wrong branch. As it stands the 7.x port has been done on an older version of 6.x.

I have applied for full project access some time ago but this is still awaiting review (see #1422616: Move Region). As soon as this is RTBC and accepted I will get in touch with the original maintainer.

jamesbenison’s picture

jamesbenison commented

Thanks for picking up the ball on this.

I'm going to check out your fork.

So we have three options:

  1. We can try to get maintainer privileges for the abandoned module.
  2. You can promote your sandbox when you are granted those privileges (which can unfortunately take a while).
  3. I'll promote this one and grant you full privileges on this project.

I'm open to any of the above.

And thanks again.

pfrenssen’s picture

pfrenssen
Location Sofia
commented

Thanks! My idea was to work on the sandbox while waiting. I can easily merge in the changes from the sandbox into the main project afterwards.

MGParisi’s picture

MGParisi commented

2 weeks have passed, do you know the next step in taking over this module, or do you need help?

jamesbenison’s picture

jamesbenison commented

Are you directing this question at me or at pfrenssen?

My understanding is that he will be taking this over.

MGParisi’s picture

MGParisi commented

Then the question is his... Id like to see this project move forword as It is close to what I need it for. Ultimately I wont be using it, but I figure I see if you all need help?

pfrenssen’s picture

pfrenssen
Location Sofia
commented

I want to volunteer as a maintainer for this project. I am currently waiting to get approved for full project access, which is a rather slow process (if anyone wants to help speeding it up by reviewing my application, the issue is here: Move Region).

I have forked the module in a sandbox and have added the D7 port and a number of patches from the issue queue to it. I intend to work in this sandbox while waiting for my promotion. I can later on merge these changes back into the main repository.

Here is the sandbox: Link Image Field (fork).

jamesbenison’s picture

jamesbenison commented

One thing that has always bothered me about this module is that it defines a new field type.

We should be able to take an "image" field and link it rather then create a "linkimage" field.

I think the solution might be right here: http://drupal.org/project/file_entity_link

I haven't tested it yet. But if it is what I think it is, we need to be using that one. Not promoting this one.

jamesbenison’s picture

jamesbenison commented

Nevermind.

The module above it appears does not allow defining a custom link as far as I can tell. But I think that's the goal we should be pursuing.

jamesbenison’s picture

jamesbenison commented

The maintainers were just contacted again by me.

Based on other work I've done in the last couple days, I'm thinking this module has a legitimate place even if it declares a new field type.

Let's just quit effing around and roll this mf out.

droath’s picture

droath commented

@jamesbenison

I forked your project and made some substantial improvements so that we don't have to declare a new field type for "linkimage". We can just use the "Image" field, and select the "LinkImage" widget to implement this feature.

Let me know what you think...

https://drupal.org/sandbox/droath/1564916

pfrenssen’s picture

pfrenssen
Location Sofia
commented

@droath Aww I wanted to merge in your changes but you have started a new repo instead of forking James' repo, making a merge impossible. Oh well.

droath’s picture

droath commented

I can't believe I forgot that part, I'm sorry! :)

jamesbenison’s picture

jamesbenison commented

@droath

I can't believe that I just reluctantly promoted this project and then just read your post after the fact.

I have been under pressure to make this official for nearly a year...and I finally caved.

I'm looking forward to checking out your project and the improvements that you have made. What was your plan? Do you have your own project waiting for approval? Do you think it makes sense if we fork a 7.x-2.x branch here that has your improvements?

I'm open to all help from all stripes to try to make this the best we can.

A big reason I've been reluctant to make this official is that I didn't think I could deliver the time to be fair to those that depend on this module.

droath’s picture

droath commented

No, I didn't submit my project for approval. I would ratter join forces with you on this project so we don't have two projects on drupal.org that do the exact same thing, but have a different approach.

I think it makes sense to create a 7.x-2.x branch, which can contain my improvements. Though I believe will need to back port some of the changes back into 7.x.1.x.

I'm open to be a co-maintainer if you would like some help moving forward. Let me know...

jamesbenison’s picture

jamesbenison commented
Version: » 7.x-1.x-dev

If you would like to be a co-maintainer that would be outstanding.

However, as another user correctly pointed out, the preferable solution is to take over the existing project (http://drupal.org/project/linkimagefield) rather than confuse users with a new one as I have just done by promoting this project. I have moved this thread (drupal.org/node/949588) over to the drupal webmasters queue to hopefully take over the abandoned project.

If you wouldn't mind, could you please post a message on there indicating that you would like to become a co-maintainer and provide a link back to your work?

Thanks for helping out with this.

jamesbenison’s picture

jamesbenison commented
Status: Active » Fixed

http://drupal.org/project/linkimagefield

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.