Closed (fixed)
Project:
Page Title
Version:
7.x-2.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
25 Sep 2011 at 05:15 UTC
Updated:
17 Oct 2014 at 11:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
ParisLiakos commentedSubscribe
Comment #2
ParisLiakos commentedi solved this with way in the attached patch
Comment #3
petrovnn commentedthank you rootatwc, yours patch works fine!
Please commit it in main branch, why it did not happen?
Why not close the issue?
Comment #4
ParisLiakos commentedBecause it needed someone like you to confirm that works!
thanks. now its up to maintainers to commit it
Comment #5
FAAREIA commentedIt works fine =).
Many thanks for the patch
Comment #6
mile23The tests in 7.x-2.x dev are much much better than the ones in 7.x-2.7, though I don't see one for behavior with a null token object.
This patch applies cleanly, though.
Comment #7
liliplanet commentedThe patch works perfectly, thank you! please commit to latest version ..
Comment #8
mariancalinro commentedFrom my point of view, displaying nothing is not a good option, you generally want to display something in your page title.
So my approach is to check the page title if it still has tokens that have not been replaced, and if so, fallback to the default pattern.
This makes sure you always have a page title, and that you do not get a page title with a token in it.
Comment #9
csanders commentedThe patch in #8 worked like a charm for me, thanks!
Comment #11
nicholasthompsonPatch in #8 applied to master in d4073217cb53681ce915f81f134e8c99904871f1.