Spanish Installation Profile

I can confirm that there are no other installation profiles like this - http://drupal.org/project/installation%20profiles?filters=bs_project_san...

I'm not sure this line makes sense - can you explain why you feel it's appropriate?
$details['file_private_path'] = 'sites/default/files/private';

I noticed some very small code style issues. Please run the coder module on "minor" setting to help catch these. The coding standards have even more information in this area. I noticed things like spaces and tabs being used interchangeably.

What is files[] = epw.profile ?

These can all be removed:

3 version = VERSION

49 ; Information added by drupal.org packaging script on 2011-06-30
50 version = "7.*"
51 project = "drupal"
52 datestamp = "1309397516"

Bien Hecho!

Yes, I think if core does that private file path then it's OK for you to set it as well. However if core doesn't then you can just leave it alone and "do the same thing core does."

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:

• ./spanish/spanish.install: comment lines should break at 80 characters, see http://drupal.org/node/1354#general
  

    // Create a editor role for site administrators, with all available permissions assigned.
  

• Comments should be on a separate before the code line, see http://drupal.org/node/1354#inline
  

  32:    variable_set('site_default_country', $details['site_default_country']); // Feel free to change to your own country, no ofenses!!!
  

This automated report was generated with PAReview.sh, your friendly project application review script. Please report any bugs to klausi.

manual review:

• put all your files in the root folder of the repository and remove the spanish subfolder.

Review of the 7.x-1.x branch:

• Lines in README.txt should not exceed 80 characters, see the guidelines for in-project documentation.
• Remove the translations folder, translations are done on http://localize.drupal.org
• @file doc block is missing in the install file, see http://drupal.org/node/1354#files .
• Comments: there should be a space after "//", see http://drupal.org/node/1354#inline
  

  spanish.install:37:  //permissions assigned.
  

• spanish.profile in spanish.info: It's only necessary to declare files[] if they declare a class or interface.
• All text files should end in a single newline (\n). See http://drupal.org/node/318#indenting
  

  ./translations/README.txt ./spanish.install ./README.txt ./spanish.info
  

This automated report was generated with PAReview.sh, your friendly project application review script. Go and review some other project applications, so we can get back to yours sooner.

Manual review:

• There are still files in the master branch. To avoid confusion, you should clean them up as described in http://drupal.org/node/1127732
• Git comments should also be in english.

I thought nothing from @doitdave was fixed, but I was actually just confused from branch master. It should have no files other than a README.txt just as specified in http://drupal.org/node/1127732.

• Lines in README.txt should not exceed 80 characters, see the guidelines for in-project documentation.
• @file doc block is missing in the install file, see http://drupal.org/node/1354#files.
• All text files should end in a single newline (\n). See http://drupal.org/node/318#indenting
  
  
  ./translations/README.txt ./spanish.install ./README.txt ./spanish.info
• Comment in ./spanish.install line 9 is in spanish. In code comments should be in english (see http://drupal.org/coding-standards)

I have noticed your git commits fix several stuff, try commiting specific code fixing one issue only. Also, please do put proper messages in commits, contributors to the project will have a bad time figuring out why a piece of code is inserted or removed if commit message lacks any information. They should be in english should you expect any help from the worldwide community.

Also, take a look at http://drupal.org/project/l10n_install to get translations imported on install, now that you removed the translations folder.

I did not try running the install profile, I just reviewed the code. Once it is fixed I will run the profile install.

Adding tag "dlatino" for reference of the Drupal Latino community.

Thanks for the coding standars review @barraponto, I have performed the fixes and will appreciated your feedback.

I'm still working on making it a localised distribution, thanks for the link!

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

This issue is not fixed? See http://drupal.org/node/532400

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Just created the full project myself.

http://drupal.org/project/spanish

I'll take care of mentoring @hatuhay and make sure that he follows the *Sacred* coding standards.

@hatuhay did not get the git vetted user role, so this application is not fixed. Feel free to open a new application once you need to promote another project.

@develCuy: why did you duplicate the project? You could have just simply promoted the existing sandbox?

@klausi, I just have permission to promote my own projects only. And what I did is to fork the repo, not just duplicated it.

Added objectives for the installation profile