I seem to have built drush commands (http://api.drush.ws/api/function/pm_parse_arguments/master) into project dependencies that are only now available in drush 5? I'm surprised. But on util, a drush pdpp <project> gets

Error: Call to undefined function pm_parse_arguments() in
/var/www/drupal.org/htdocs/sites/all/modules/project_dependency/project_dependency.drush.inc,
line 59

We currently have drush 4.5 in /usr/local/sbin/drush/drush on util, and devwww has Drush 4.2. I'm not sure about other servers.

Comments

msonnabaum’s picture

msonnabaum commented

Drush 5 is still very much in flux, I wouldn't recommend using it in production.

However, I'm not against backporting just this function to 4 (I can't backport the commit it was a part of), so it would be in 4.6.

When I've had this issue, I usually just put the missing functions I need in a drush5.inc and do something like:


if (version_compare(DRUSH_VERSION, '5', '<')) {
  require('drush5.inc');
}

It's ghetto, but it works.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Title: Update drush on util (and other infra) to drush 5.x » Install drush 5 as /usr/local/sbin/drush5 on util (and other infra)

OK, to overcome inertia: Can we just install drush 5 in /usr/local/sbin/drush5?

If we need manual dependency builds they should be done by jenkins; I'm trying to make drupal.org_build-dependencies work, and drush 5 is certainly the fastest route.

sdboyer’s picture

sdboyer commented

as a crappy short-term solution to this for the git VMs, i've made a drush5 module in puppet that, as with the current module, contains a tarball. we can switch individual nodes over to it as needed/desired.

ideally we'd wrap this all in one module and use pear for the installer, then maybe allow each node to specify the versions it wants via a var in its manifest/conf.

senpai’s picture

senpai commented
Title: Install drush 5 as /usr/local/sbin/drush5 on util (and other infra) » Upgrade Drush to v5 on all servers

Want. Need. Desire. Bumping.

senpai’s picture

senpai commented
Assigned: Unassigned » nnewton

Assigning to @nnewton

nnewton’s picture

nnewton commented

After discussing with drumm, we decided to just push this to dev and staging. This is now done.

senpai’s picture

senpai commented
Status: Needs review » Fixed

I guess this is fixed then.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Fixed » Needs review

Still not on production.

nnewton’s picture

nnewton commented

rfay is there a reason drush5 is needed on production right now? (I understand you were likely just correcting the close based on title, but this issue was confusing and I want to make sure you didn't have a reason for it to be pushed to prod)

-N

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented

@nnewton, no, there's no rush. Just didn't figure the issue was fixed until it was deployed.

I have been living with a private drush5 for like a year or more so not going to affect me in the short term...

drumm’s picture

drumm
he/him
Location NY, US
commented
Assigned: nnewton » drumm

We should run through all the drush usage to see if anything breaks. That's probably my job.

drumm’s picture

drumm
he/him
Location NY, US
commented
Assigned: drumm » nnewton
Status: Needs review » Reviewed & tested by the community

It looks good and we are running into problems because production has an older version.

nnewton - please deploy at your convenience

moshe weitzman’s picture

moshe weitzman commented

Any chance we can do this?

drush6 will be out very soon. Perhaps someone can deploy that as drush6 and elave drush5 as `drush` until 6 is more battle tested. thanks.

jeffsheltren’s picture

jeffsheltren commented

I'm maintaining some drush RPMs for use with multiple clients and they may provide an better and/or easier way to deploy/manage drush across all the drupal.org systems. drumm or nnewton: let me know if you want to discuss/review. http://pkg.tag1consulting.com/drush/

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Reviewed & tested by the community » Fixed

Production has Drush 5.4.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Closed (fixed) » Needs work

util is still drush 4.2 and local drush (in my homedir) stopped working as of today.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

So, util needs to be upgraded to 5.x and it looks like the rest of the servers are on 5.4 while a newer version is available.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented

Just FYI, @greggles there is a pseudo-legitimate drush5 at /var/www/drupal.org/tools/drush5/drush

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

@rfay it seems to not be working as of today.

[greggles@www2 commons]$ /var/www/drupal.org/tools/drush5/drush -v
-bash: /var/www/drupal.org/tools/drush5/drush: /usr/bin/env: bad interpreter: Permission denied

dww’s picture

dww
we/he/they
commented
Category: task » bug

LOL @ "pseudo-legitimate drush5" Awesome. ;)

But ugh, that's bad if it's dead, since that's what the packaging script uses for distribution packaging. :/

Confirmed that it's broken for me, too. Escalating this to a bug, although we should probably just open this bad interpreter thing as a separate issue...

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

@dww - yeah, there's a related issue at #2065651: Error parsing whitelist.

ezra-g’s picture

ezra-g commented

It seems possible that #2066525: Pushed git commits and tags are delayed, unable to create release nodes is related to this issue.

ezra-g’s picture

ezra-g commented
Issue summary: View changes

devwww has Drush 4.2

Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
commented
Issue summary: View changes
Status: Needs work » Closed (fixed)

drush 5.8 and drush 6 are on devwww as drush6, if there's anywhere else that drush needs to be, please open another issue.

Component: Webserver » Servers