The filter options are not fully visible. Best described by the image attached.

Thanks!

CommentFileSizeAuthor
#7 octopus-eldir_filters-1317322-7.png14.07 KBmrP
#7 octopus-eldir_filters-1317322-7.patch302 bytesmrP
#1 eldir - normal.png38.34 KBsteven jones
aegir-hostmaster-eldir-theme-filter-bug.JPG48.05 KBtne_

Comments

steven jones’s picture

steven jones commented
Status: Active » Postponed (maintainer needs more info)
StatusFileSize
new eldir - normal.png38.34 KB

Attached is a screenshot of the standard Eldir theme supplied by Aegir.

Does octopus add anything here to make it look broken, I guess it must?

omega8cc’s picture

omega8cc commented
Project: Hostmaster (Aegir) » Octopus
Version: 6.x-1.4 »
Status: Postponed (maintainer needs more info) » Needs work

This is a known issue - we are using a patch like below:

+.form-submit {
+  width: 25%;
+  text-align:center;
+  display:block;
+  margin-top:15px;
+  margin-left:auto;
+  margin-right:auto;
+}

It makes all submit buttons nicely centered, to make it good enough also for right handed people, because Drupal default, which is left align is silly, IMO.

The price is that in some locations it gives unexpected results.

This needs more work, probably.

tne_’s picture

tne_ commented

Is it really neccessary to consider left/right hand handling? I might be overlooking something, but according to "action buttons" there are a lot of learned lessons. For one, i do not think that buttons need to be centered - they can also be aligned on the right or on the left.

For example, if you remove "width: 25%" it should be accessible on all forms and not be misplaced. Maybe for now this solution helps to fix the broken button elements, and reconsider an updated ui concept in a next step.

omega8cc’s picture

omega8cc commented

Well, we did that not by accident, it was a design decision for Octopus and it works perfectly in all Aegir forms, while breaks only some non-Aegir, standard Drupal forms. We don't plan to change this, rather to fix it to avoid breaking non-Aegir forms. Note that removing width: 25% reverts it to standard left align.

omega8cc’s picture

omega8cc commented
Priority: Normal » Minor
omega8cc’s picture

omega8cc commented
Status: Needs work » Postponed
mrP’s picture

mrP commented
Version: » 6.x-2.x-dev
Issue summary: View changes
Status: Postponed » Needs review
StatusFileSize
new octopus-eldir_filters-1317322-7.patch302 bytes
new octopus-eldir_filters-1317322-7.png14.07 KB

boy, this one's been around a while. setting a min-width would be one easy option.

omega8cc’s picture

omega8cc commented
Status: Needs review » Fixed

Looks like a good workaround. Committed in http://drupalcode.org/sandbox/omega8cc/1074912.git/commit/31b2747

Thanks for the patch!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.