In our (entity) data source controller's loadItems() method, we should remove items from tracking if they couldn't be loaded successfully. This helps to avoid problems when an entity was removed but the appropriate hooks for some reason weren't called. (It also cleans up after our previous temporary problem where entity deletes weren't correctly registered.)

CommentFileSizeAuthor
#2 1319500--deleted-items-cleanup-2.patch797 bytesdrunken monkey
#1 1319500--deleted-items-cleanup-1.patch967 bytesdrunken monkey
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey commented
Status: Active » Needs review
FileSize
1319500--deleted-items-cleanup-1.patch967 bytes

Patch attached.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey commented
FileSize
1319500--deleted-items-cleanup-2.patch797 bytes

Slightly cleaner way to do this.

mh86’s picture

mh86 CreditAttribution: mh86 commented
Status: Needs review » Reviewed & tested by the community

Adding this check is probably a good idea, and it doesn't hurt if everything is fine.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey commented
Status: Reviewed & tested by the community » Fixed

Great, committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.