Generate an upgrade makefile from an existing makefile?

marked a duplicate of this: #740892: simple way to re-generate make file with best version updated

[ Powered by #1115636: Issue Macros and Templates - Drush Make]

Drush make is being merged into drush core (discussed in issue:#1310130: Put drush make in drush core)
This means that the issue queue is also moving. The drush queue has a component 'Make' especially for drush_make.

More information will be posted on the drush_make and drush project pages.

I am again going to vote that this should be "won't fix" for the same reasons given here.

make-generate better be very very good at its job in order for that to be a replacement. it isn't good if there are spurious diffs because re-make is lossy. i really haven't used make enough yet to know more.

Yes, good point. Libraries, for one, are hard to reconstruct, as their source URL and other attributes are not recorded.

I propose that make-generate be enhanced to run in any of three modes:

1. Generate from an existing site (current implementation)
2. Generate from a makefile (no installed site available)
3. Generate from info from both an existing site, and the makefile that generated that site

Drush can use pm-releases in the second mode to get the current version information for the provided makefile in the second mode. In the third mode, the provided makefile will be largely (but not completely) ignored, as the module enabled/disabled status of the current site will take precedence. The provided makefile will be consulted as needed, e.g. to provide the download URL for modules where that information is not available.

I posted a patch in #1212686: Create a versioned make file when running drush make with option --make-generate that might be helpful in this issue too.

The latest patch in #1212686: Create a versioned make file when running drush make with option --make-generate should make this issue relatively easy.

Re. #6, I'm not sure that I understand what (3) is referring to... is it basically #1212686: Create a versioned make file when running drush make with option --make-generate or something else entirely?

I edited #6 for clarity. If a user generates a site with a makefile, and then later updates the site with pm-updatecode, it would be useful to run a command to generate an up-to-date makefile, using information from the original makefile (which may not be available using just the installed site, per #4), and information from the current site (exactly what versions of everything were installed at the time pm-updatecode was ran).

Okay, well then I think (3) from #6 (as much as it'd be an interesting feature) is actually out of scope for this issue. At least, as it was initially described.

Here's a patch that builds on #1212686: Create a versioned make file when running drush make with option --make-generate. It allows both versioned and updated makefiles. It also adds a 'no-build' option, so that it can generate these without actually having to build a codebase.

Yes, I agree #6 (3) is a separate issue. Thanks for working on this. Code here & in other issue looks good, but I haven't had time to try it or review it carefully.

I figured to bump this issue, since it's been a couple weeks. Bit rot may require a re-roll of the patch, so let me know if it doesn't apply cleanly.

Also, the patch is really only about half it's apparent size, since half of it is just moving a couple functions out of generate.make.inc and into their own file, to allow the to be called separately.

I'm still absolutely swamped, for weeks to come. Maybe Jonhattan can review? Code looks good overall.

Opened a new issue on github: https://github.com/drush-ops/drush/issues/53