Screen-reader users receive information if file upload was successful

Or for that matter, that it failed. Pretty sure that this wouldn't be reported to AT either:

        var error = Drupal.t("The selected file %filename cannot be uploaded. Only files with the following extensions are allowed: %extensions.", {
          '%filename': this.value,
          '%extensions': extensionPattern.replace(/\|/g, ', ')
        });
        $(this).closest('div.form-managed-file').prepend('<div class="messages error file-upload-js-error">' + error + '</div>');

I took a quick look and couldn't find a "Success" announcement. Believe it just stops loading and appears. Maybe a happy message would be useful to display for everyone for when there is a success.

This is related to #1272990: Make tabledrag warning message show when row weights are enabled, and add WAI-ARIA live region - a generalized solution would be very useful here.

Tagging.

This is a good place to use WAI-ARIA to add the change of state.

Not addressing the successful image upload, but the case of failure suggested in #2.

#7: fileupload-1333292-7.patch queued for re-testing.

tagging. This should be backported to D7. It's an admin thing, but also something that is part of many public user input forms.

Committed and pushed to 8.x. Thanks!

Moving down to 7.x.

Backported #7 to D7.

12: 1333292-12-file-upload.patch queued for re-testing.

Well, I can't seem to see either the file-upload-js-error class or aria-live="polite" when I upload a file here node/add/article

I'm missing something.... But ya, it shouldn't take a year to backport an issue to D7.

EDIT: Any illegal file type should be sufficient to tell you that it failed, right?

12: 1333292-12-file-upload.patch queued for re-testing.

This still works as expected when I tested it manually today.

Committed to 7.x - thanks!

Sounds like this should go back to Drupal 8 though, since the original issue was about what happens when the file upload is a success?

Agreed.. Would be good to have a positive confirmation as well. Thanks @David_Rothstein.

adding related issue.

@mike the related issue looks like a mistake - this issue is referencing itself. Did you mean for some other issue to reference this one?

Yup, seemed to have made a mistake there. I've done that before too...

This is better, but think I'd stumbled across another one.

Thanks for pointing it out!

Changing the title to reflect the current problem.

No work has been made to create a positive confirmation of file upload, so I am bumping this to 8.1 for now.

We should be using Drupal.announce() for announcing both the successful & failed uploads.

Patch no longer applies.

Afik this was fixed already, at least the aria-live="polite" is there.

I haven't tested this recently, but am pretty sure it is fixed if the file fails, but not if it is successful.

Tested using NDVA; Chrome on Windows in D 8.4.x

Tested failed file upload; NDVA screen reader reads:
Alert specified file could not be uploaded
Create [website name] document
Second line of error message is not read out

Duplicate error message displays on page.

On success; no message is read out if successful

On successful upload screen reader reads out [site name ] + link [file name] eg filename.doc

I've lost track of where this issue is at, or what we're still trying to fix.

I ran a quick manual test with the user picture field, trying to upload a file which was too big:

The aria-live="polite" attribute introduced by patch #7 (committed already in D8) is in Drupal.file.validateExtension(), but I can't get this to appear in the DOM. I don't think this javascript is firing, because:

• The screenshots in #38 say "The specified file ..." but the message in Drupal.file.validateExtension() is phrased "The selected file ...".
• The message is wrapped with a <div role="alert">, not a <div aria-live="polite">

I think this is probably a generic form error message being returned by the AJAX system.

Some other things I noticed:

• I only see one copy of the message when testing with Chrome (v59 on Linux).
• In a test with ChromeVox, it did start reading the second line of the message, but cut out before finishing. It said "The file is eleven-" but didn't go as far as finishing the sentence. I wonder if there's a timing issue here? Maybe some other event interrupting the screenreader, or a maximum time self-imposed by the screen reader. It consistently cut out at the same part of the message.

This was committed to 8.x in Jan 2013. It was re-opened in #14 because the patch failed manual testing for the case of a successful file upload. This was committed to 7.28 in May 2014. I don't see any testing to confirm if that work for the case of a successful file upload. This issue bounced a bit between Drupal 7 and Drupal 8 and despite the commits this was never marked fixed.

As it stands this issue is about ensuring that screen-reader users receive information that a file upload was successful. I know that is the intent of the title but it hasn't turned out that way. Since this was never reverted and it has been 4 years since the last testing I think the best way to make progress is to close this and open a new issue. Experience in bug smash initiative is that issues like this that get re-opened tend to become difficult to follow and don't get a lot of attention and then there can also be confusion if there are two commits referencing the same issue number.

Made a new issue #3244803: Ensure that screen-reader users receive information that a file upload succeededul and moved credit. Further work should happen there.

Closing this a fixed.

Changing version to the version of the commit