Issues when Hierarchecal Select is inside Field Collection

I concur. Same problem.

I also have this problem. I will also try a custom solution.

I've rewritten the _hs_process_determine_hsid function to make it work until it is fixed by the maintainers:

function _hs_process_determine_hsid($element, &$form_state) {
  // Determine the HSID to use: either the existing one that is received, or
  // generate a new one based on the last HSID used (which is
  // stored in form state storage).
  if (!isset($element['#value']) || !is_array($element['#value']) || !array_key_exists('hsid', $element['#value'])) {
    //we use field-collection's delta as hsid
    if ($element['#entity_type'] == 'field_collection_item' && isset($element['#parents'][2])) {
      $hsid = $element['#parents'][2];
    }
    else {//other cases
      if (!isset($form_state['storage']['hs']['last_hsid'])) {
        $form_state['storage']['hs']['last_hsid'] = -1;
      }
      $form_state['storage']['hs']['last_hsid']++;
      $hsid = $form_state['storage']['hs']['last_hsid'];
    }
  }
  else {
    $hsid = check_plain($element['#value']['hsid']);
  }

  return $hsid;
}

The issue with HS is that $hsid is calculated incorrectly when inside a field collection, so I'm using the field-collection's delta for a hsid

Tried to implement your change and I don't notice a differenct. Are you just updating the function in the hierarchical_select.module file?

yes, I've updated it. Have you tried to debug it? Did it go into

if ($element['#entity_type'] == 'field_collection_item' && isset($element['#parents'][2])) {
  $hsid = $element['#parents'][2];
}

condition?

I also tried it, and debug it,

$element['#parents'][2]; has a value, and it is getting inside the condition, but still erasing all of the hierarchical select fields when saving, here is my example -> http://www.youtube.com/watch?v=b5aKhVK9WmY

The bug is still happening

Thanks!

Same problem.
I have this problem also if I use Field Group Multiple instead Field Collection.

@dmitry.n :
I added your code but D7 put this error:

Notice: Undefined index: #entity_type in _hs_process_determine_hsid() (linea 354 di /media/dude/www/prova/sites/all/modules/hierarchical_select/hierarchical_select.module).

This patch worked great for me. You may need to wikipedia diff to understand the syntax, I applied it manually.

http://drupal.org/node/1466516

Yep, it works fine (:
"git patch" and "patch" are not worked for me. i have added manually code. and it start works (:

in attachment module (7.x-3.0-alpha5) what works fine if replace it (:

Thanks, It resolved that issue.

Now we are facing another issue when I am trying to remove a field collection item from the node edit form, it is removing the field collection item and it shifts removed FC item's hierarchical select field values to succeeding field collection items.

Please check the attached screenshot images.

Example:
FC : Field Collection
FXX : Field's in field collection.
HS : Hierarchical Select

 FC1
    F11
    F12
    HS1
      
 FC2
    F21
    F22
    HS2

 FC3
    F31
    F32
    HS3 

 FC4
    F41
    F42
    HS4

Lets say i have removed Field Collection1(FC1), see the changed structure below

FC2
    F21
    F22
    HS1
 FC3
    F31
    F32
    HS2 
 FC4
    F41
    F42
    HS3 

This issue is resolved by adding below condition to the code drupal_array_set_nested_value($form_state['input'], $element['#array_parents'], array()) in form_hierarchical_select_process function.

function form_hierarchical_select_process($element, &$form_state, $complete_form) { 
  .
  .
  .
  // This prevents values from in $form_state['input'] to be used instead of
  // the generated default values (#default_value).
  // For example: $element['hierarchical_select']['selects']['0']['#default_value']
  // is set to 'label_0' after an "Add" operation. When $form_state['input']
  // is NOT erased, the corresponding value in $form_state['input'] will be
  // used instead of the default value that was set. This would result in
  // undesired behavior.
  if (empty($docache)) {  /* Condition */
    drupal_array_set_nested_value($form_state['input'], $element['#array_parents'], array());
  }
  .
  .
  .
}

Thanks

Thanks devasena,
it was helpful!

I'm attaching updated patch file for hierarchical_select.module.

Rerolled patch to 7.x-3.x-dev

This is not even close to RTBC, sorry.

1. +++ b/hierarchical_select.module
   @@ -690,11 +690,25 @@ function _hs_process_render_nojs($element, $config) {
   +  // @TODO: verify if we have AJAX call.
   

   This cannot be RTBC if there's still a @todo

2. +++ b/hierarchical_select.module
   @@ -690,11 +690,25 @@ function _hs_process_render_nojs($element, $config) {
   +    //Get unique identifier using parents of the field
   ...
   +    // verify if hsid is present or not.
   ...
   +      // switch courrent element with the "cached" one.
   

   Punctuation!

3. +++ b/hierarchical_select.module
   @@ -690,11 +690,25 @@ function _hs_process_render_nojs($element, $config) {
   +    $elhsid = drupal_array_get_nested_value($element, array('#value', 'hsid'));
   

   s/$elhsid/$hsid/

Closed as duplicate #1466516: Error adding new field collection with Hierarchical select inside because the patches are the same

Here is my implementation of this issue fix (patch is bit modified combination of existing patches).

Please re-roll to address minor nitpick, otherwise RTBC

+++ b/profiles/mcdonalds_testimonials/modules/contrib/hierarchical_select/hierarchical_select.module
@@ -359,6 +359,11 @@ function _hs_process_determine_hsid($element, &$form_state) {
+  ¶

@@ -807,8 +827,14 @@ function form_hierarchical_select_process($element, &$form_state, $complete_form
+  ¶

trailing white spaces

Trailing white spaces was removed

Finnaly this works!

Fixed path to module on patch.

Darn, path in the patch

Patch in #25 seems to do the trick for me. My only remaining request would be that the HS field is reset (like other fields are) when you remove the last remaining item in a field collection.

Thanks!
Kirk

I have the same problem but using version alpha6.

Does anyone know if this can be patched for alpha6 too ?

Regards

-G

Not working for me either - HS will not show the next dropdown after I choose a value - no errors thrown in the console - tried #25 but no difference

I am now using alpha5 but could not patch this correctly. Getting malformed patch error. Any help?

#21 works fine...thanks

Re-rolled on dev snapshot.

I'm not sure this fixes it. I am still having problems, but my site has lots of those... ;)

Committed, thanks!