Hi,

It would be great to display the group name of a migration on the migration dashboard (and when we use the "drush ms" command) to be able to quickly see and a migration use the group feature and what migration belong to wich group.

CommentFileSizeAuthor
#5 without-space-changes.diff.txt1.66 KBmarvil07
#4 0001-Issue-1350284-Let-drush-migrate-status-show-migratio.patch4.53 KBmarvil07
#1 1350284.display_migration_group.patch2.02 KBhaza

Comments

haza’s picture

haza
Primary language French
commented
Status: Active » Needs review
StatusFileSize
new 1350284.display_migration_group.patch2.02 KB

The patch is attached.

Group is display on "admin/content/migrate" and also when using "drush ms"

A quick look on what it may look like :

migrate ui

drush ms

What do you think about that ?

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Status: Needs review » Needs work

Actually, what I always had in mind (but never got around to implementing) is visually grouping the migrations, something like this for drush ms:

Group: default         Total  Imported  Unimported  Status     Last imported       
 BeerTerm              3      3         0           Idle       2011-11-26 11:54:04 
 BeerUser              4      4         0           Idle       2011-11-26 11:54:05 
 BeerNode              3      3         0           Idle       2011-11-21 17:38:18 
 BeerComment           5      0         5           Idle       2011-11-21 17:38:36 

Group: wine            Total  Imported  Unimported  Status     Last imported       
 WinePrep              N/A    N/A       N/A         Idle                           
 WineBestWith          3      0         3           Idle       2011-11-21 17:38:15
drewish’s picture

drewish commented

+1 on the grouping. i'd rather not see the list get any wider.

marvil07’s picture

marvil07 commented
Status: Needs work » Needs review
StatusFileSize
new 0001-Issue-1350284-Let-drush-migrate-status-show-migratio.patch4.53 KB

Here a patch for migrate-status output.

I first tried with one drush table per group, but I end up doing it all in one table because IMHO that looks easier to read(all columns at the same width).

In the other side, I guess it is ok to have one more column on the web version at migrate_ui. We could have the grouped html tables(but yet it could be the same problem I mentioned on the last paragraph).

marvil07’s picture

marvil07 commented
StatusFileSize
new without-space-changes.diff.txt1.66 KB

btw, here a ignore-all-space-version of the patch for easier review.

wusel’s picture

wusel commented

+1 on the grouping #5.

My suggestion for the "Migrate UI":
Add the group on all tabs "Overwiew" of the group, if needed.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Status: Needs review » Active

Committed to D6 and D7, thanks!

Leaving this issue open for the sake of migrate_ui...

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Issue tags: +Migrate 2.6

Tagging for 2.6.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Status: Active » Fixed

This was committed to the wizard_api branch, which is now merged to 7.x-2.x.

Automatically closed -- issue fixed for 2 weeks with no activity.