Hi. I'm sure there are plenty of people that would appreciate if someone would update this module for Drupal 5.x.

CommentFileSizeAuthor
#3 geshifilter.tar__0.gz543.09 KBthumb
#2 geshifilter.tar_.gz707.17 KBPhong

Comments

liqweed’s picture

liqweed commented

I've ported the module to v5.1. The porting involved the following files:

  • geshifilter.module (modified)
  • geshifilter.info (added)

I did the porting according to the "Converting 4.7.x modules to 5.x" article, and it was rather easy (It's a very lightweight wrapping module around GeSHi, great stuff).

I'm new to Drupal, this is my 2nd day using it (loving it so far), so I might have missed out on a few details.
It does work though.

It seems as if I can't upload zipped files.
How do you suggest I should publish the code?

Phong’s picture

Phong commented
StatusFileSize
new geshifilter.tar_.gz707.17 KB

I too have ported the code as well as reorganised some of the codebase and corrected some typoes.

I have attached the patched file to this comment.

thumb’s picture

thumb commented
Assigned: Unassigned » thumb
Status: Active » Needs review
StatusFileSize
new geshifilter.tar__0.gz543.09 KB

I've cleaned up Phong's code further (compact style, quoting, indentation) and corrected path information to enable this filter to work in multisite installs. The module can now be installed in either sites/all/modules or sites/mysite/modules.

I've tested against my Drupal 5.1 install and it's been working okay.

zoliky’s picture

zoliky commented

Sorry because I write here... but someone try to help with this problem: http://drupal.org/node/156808 ?
I think geshi filter need some fix..

Thanks!

bloomaniac’s picture

bloomaniac commented

could this be commited to head? a release for 5.x would be helpful too?

thumb’s picture

thumb commented

I suspect it could, but it requires review by a Drupal contributor. I don't think anyone in this thread has CVS privileges.

pitpit’s picture

pitpit commented

thumb,

Would you like to apply for a csv account and become maintainer of this module ?

http://drupal.org/cvs-account

thumb’s picture

thumb commented

Sure, why not? :) Just applied for a CVS account.

soxofaan’s picture

soxofaan commented
Assigned: thumb » soxofaan

Yesterday I got a CVS account and got maintainership for GeSHi filter. I already branched it for Drupal 4.7 (DRUPAL-4-7) in preparation of port to Drupal 5. (http://drupal.org/node/104567#comment-290820). Tomorrow I will have a look to all the "port to Drupal 5" patches in the tracker and pick the best one.

thumb’s picture

thumb commented

That's great soxofaan. Look forward to being able to manage my install through CVS :)

soxofaan’s picture

soxofaan commented

The 4.7 version was minimally patched to get it working with drupal 5 and is branched as DRUPAL-5, which is available as a development snapshot on http://drupal.org/project/geshifilter or through CVS of course.
Submit additional patches against DRUPAL-5 as new issues, please.
I'll will close this issue later.

soxofaan’s picture

soxofaan commented
Status: Needs review » Closed (fixed)

first release of the port to 5.0:
http://drupal.org/node/171767

closing this issue
new issues should now be submitted against the right version