Closed (won't fix)
Project:
Drupal core
Version:
8.0.x-dev
Component:
markup
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
1 Dec 2011 at 20:26 UTC
Updated:
29 Jul 2014 at 20:13 UTC
This is a simple patch that does the following:
h1h2hgroup elementCurrently, the site name is wrapped in p element, unless there is no page title (which then displays as h1). From what I understand, this is no longer necessary in HTML 5 because of the sectioning content model.
Also, the wrapping of the hgroup with an if statement so it only appears when both the site name and slogan is what is specified in the HMTL 5 specs. hgroup should not be used when only one sectioning element is present. Personally, I also like the idea of removing unneeded wrapper anyways.
Rene
| Comment | File | Size | Author |
|---|---|---|---|
| convert_site_name_slogan.patch | 1.41 KB | rhache |
Comments
Comment #1
rhache commentedadding html5 tag to issue
Comment #2
jacineHi @rhache!
Many of us use
<hgroup>in our personal themes. The reason we didn't introduce it in page.tpl.php is because it's still sorta on the chopping block. There are people actively trying to get it removed from the spec.I think the best thing to do here is postpone this issue for a while and revisit it after some time passes and reassess. If it's still there, we can discuss adding it in for sure.
Comment #3
rhache commentedI know hgroup has been in and out in the specs, so what about just changing it to a div for now.
The h1/h2 for the site name and slogan is still valid and better implementation that what's there currently.
Rene
Comment #4
akizuky commentedWhile I was looking at this I found that this div wrapping has been done with the recent migration to Twig templating system. The hgroup tag is out of the specification, so closing the issue.
http://lists.w3.org/Archives/Public/public-html-admin/2013Apr/0003.html