This module sounds nice, and actually its functionalities are so needed.
But still seems immature, buggy and tricky ...

Here are some bugs I found, quickly testing it:

-1 the first invoice is correctly created when an order status becomes "completed" (good), but every time I try to update/save the order, without changing it (also just for fun, as I like it ...) a new, and new, and new, invoice is generated, referring to the same order id (!!!), and this is (seems to be) absolutely wrong. Am I right? This shouldn't really happen ...
-2 if I changed the order status form "complete" to pending", or I deleted it, any invoice related to it wouldn't be deleted. This makes me very doubtful, too.
-3 role permissions for authenticated users in the default view for invoices seem not to work well. I am not able to make the invoices linked to orders visible for users with "view own invoices" permissions granted ...

In summary: this module is very meaningful in the Drupal Commerce context, but seems to be still to immature and buggy. And this is a real pity ... more careful uses cases should be studied and implemented.

Really keep hope in further development and since now I thank you for that

Comments

itamair’s picture

itamair commented
Priority: Normal » Critical
itamair’s picture

itamair commented
Priority: Critical » Major

updated status

guillaumev’s picture

guillaumev commented

To answer your remarks:

1. Yes, there is a bug here, and an invoice should not be generated multiple times for the same order. I'll see if I can fix this.
2. Now I don't agree with that one. I'm not a professional accountant, but I believe that, once an invoice has been generated, it should never be deleted. If you made a mistake and need to reimburse some money to your customer, you need to create him a "credit note", so I think (but I wouldn't mind having an opinion from someone who has more accounting experience than I do) that Commerce Invoice's behaviour is right...
3. Yes, there seems to be issues there, see http://drupal.org/node/1322256. I'll see if I can fix those as well...

Also, please don't hesitate in providing patches for these issues you are mentioning, they will be very welcome...

guillaumev’s picture

guillaumev commented

Done for 1: http://drupalcode.org/project/commerce_invoice.git/commit/9839b45

itamair’s picture

itamair commented

Thank you so much! A patch for the #1 is a good progress ...
Would be great to solve also the #3 ...
I agrre with you for the #2 task.

My Drupal skills are not so mature to produce patch so easily, but will let you know if something comes out from me, anytime.

In the meanwhile I was trying to compare the different solutions now available on the Drupal Commerce Invoice matter side ...
Among the others (Commerce PDF Invoice, Commerce Invoice Receipt, ecc.) this one seems the most solid module as it creates the invoice entity, while the others seem just to give a better order reporting ... that might not be sufficient and realistic in a real commercial workflow (orders and invoices shouldn't necessarily be synonyms ...)
Anyway I posted a thread on the Drupal Commerce site: http://www.drupalcommerce.org/node/1210
asking to push efforts in synthesizeing the invoice implementation solutions for Drupal Commerce, as I think is something should be really strengthened as a mature functionality.
but so far any answer about it ...
Commerce PDF Invoice functionalities are quite nice, but this module is not so actively maintained and shows some critical/major issue, like this: http://drupal.org/node/1270816 that makes it quite unusable. And its maintainer seems not to give quick feedbacks ... and solutions.

Thanks a lot guillaumev for your commitments on this/your nice module ... very promising. Hope will soon at least a beta version ...

itamair’s picture

itamair commented

would be really nice to have this http://drupal.org/node/1322256 fixed soon.
I have mixed this module with the print one (http://drupal.org/project/print) and seems to integrate very well.
I think that once fixed the "view own invoices" permissions matter, this module will become the ONE for invoices management with Commerce.
I will stay tuned, with finger crossed ...

guillaumev’s picture

guillaumev commented

For 3, please see http://drupal.org/node/1322256, it should be fixed...

For 2, I think it could be interesting to get information from an accountant... Should the delete functionalitity be implemented or not ?

guillaumev’s picture

guillaumev commented
Status: Active » Closed (fixed)

I'm going to mark this issue as fixed.

For "view own invoices" permissions, let's switch to this issue: http://drupal.org/node/1322256

For the possibility to delete invoices, let's switch to this issue: http://drupal.org/node/1286030

I think it's better to have each discussion in a specific issue, instead of mixing everything in a single one...

itamair’s picture

itamair commented

Great! Thanks in advance ... I will check soon, and report if anything else goes wrong (after deep testing ...)