[D7] Webform userkey

You got a few coding style issues, please try to fix them (See http://ventral.org/pareview/httpgitdrupalorgsandboxdk1291367780git, you can use this site your self to re-review it)

If you have any questions on this, please ask!

for some reason the online service hung up, but after a reboot it seems to work again :/
http://ventral.org/pareview/httpgitdrupalorgsandboxdk1291367780git

Changed priority from 'major' to 'normal'.

Your priority should not be at 'major' it should only be at 'normal'. The former setting is only for projects that have been awaiting review for 2 weeks or more in line with the project review guidelines.

Hi

Please be more descriptive in README.txt about how the module is useful and how it can be used (see Provide a useful README.txt on http://drupal.org/node/161085). Obviously you think its a useful module to have, but I cannot see why I might want to install it. Share your enthusiasm with us.

Please add package = Webform to the .info file so that users can easily find this module under the Webform heading on the Modules page when installing (see Follow package naming conventions on http://drupal.org/node/161085).

@dk129: I've been playing with your module and I have two questions:

1) Why is this module Webform-specific? Other nodes types also get programatically loaded etc. It could be more general, i.e. act on the node table, rather than the webform table.

2) Do we really need a userkey to identify a node? I mean, it would be as easy (or difficult) to use the node title. The node table already has a node_title_type key.

Oops, should have changed status earlier.

Two things.

1. If you alter another module's table, you should also alter the database's schema: hook_schema_alter. You do this for the next module and to always have a matching schema.
2. This doesn't add a URL thing? The interface is only programmatic?

When calling the function with a key that doesn't exist:

Warning: array_flip(): Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->load() (line 178 of /var/www/quadrupal7/includes/entity.inc).
Warning: array_flip(): Can only flip STRING and INTEGER values! in DrupalDefaultEntityController->cacheGet() (line 354 of /var/www/quadrupal7/includes/entity.inc).
Notice: Trying to get property of non-object in webform_client_form() (line 1694 of /var/www/quadrupal7/sites/all/modules/contrib/webform/webform.module).
Notice: Trying to get property of non-object in webform_client_form() (line 1707 of /var/www/quadrupal7/sites/all/modules/contrib/webform/webform.module).
Notice: Trying to get property of non-object in webform_client_form() (line 1713 of /var/www/quadrupal7/sites/all/modules/contrib/webform/webform.module).

This is bound to happen, so should produce less PHP Warnings + Notices. The result is a renderable array, that's not a webform.

Closing as applicant wants to apply with another module:
http://drupal.org/node/1498566