Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.When a node is in another language as the interface language, we have mixed languages on one page.
We already fixed to add the language and direction attribute in #1164926: Nodes need to have languages specified separately for accessibility, but the labels and comment sections are not aware of this. What we see now is the node language technically is also attached to the comment section and labels as well, while the visible language for these elements is now in fact the interface language. The technical language and the visual language should be the same for these elements.
Not sure what the correct language should be:
- If a node is in another language as the interface language, should we print the labels in the node language as well?
- Or should we print the labels in the interface language?
- And do we expect comments in the node language or in the interface language?
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | english_in_arabic.png | 175.97 KB | Hanno |
| #2 | arabic_in_english.png | 188.51 KB | Hanno |
Comments
Comment #0.0
Hanno CreditAttribution: Hanno commentedissue tagged
Comment #1
Gábor HojtsyField labels are not translatable in core, so we cannot really display them in any other language but what was entered. They should eventually become translatable with the introduction of CMI's backend/API and its application to field settings, if/when that API supports languages and translation. So I don't think we can do anything with labels at the moment.
For comments, I think that is an unrelated issue to labels, since comments are user input, they are usually not translated per say (at least I've never seen sites where comments were stored in multiple languages). So applying language there means filtering the list of comments displayed based on language, right? Not translating them to some language. Does core have that capability? (I have not looked). You seem to say it currently does filter comments and it does so based on the interface language(?). Or are you referring to the comment form and/or the comments header text?
Comment #2
Hanno CreditAttribution: Hanno commentedWell it is a bit hard to explain and will only show in certain situations. Attached two screenshots: arabic text in English interface and a English text in an Arabic interface. According to the direction you can see that the language and direction doesn't correspond to the used language. 'Submitted by' and the comment form are in the wrong direction (and language attribute).
The surrounding interface is Arabic, so should the comment form in Arabic or in English? Should 'submitted by' be in arabic? It is now a mix: visible is arabic language, but it is in LTR and with the english language tag
Here an 'Arabic' text, correctly RTL. The surrounding interface is English, so should the comment form in English or in Arabic? Should 'submitted by' be in english? It is now a mix: visible is the English language, but it is in RTL and with the arabic language tag. Also note that 'Body' is in english, but in RTL. The title should be RTL and arabic, but is LTR and english, but that is hard to tackle as title is at the moment not part of node.tpl.php. When printing teasers it is correct.
Comment #3
Hanno CreditAttribution: Hanno commentedAltered title as labels aren't translatable at the moment. Has to wait to CMI. #1157426: Field system uses t() incorrectly and inconsistently.
First focus on the input form? Should the interface language of the comment form be in the node language, or the interface language?
Choosing the interface language is more consistent, but that introduces language complexity in nodes. For example, if there is a share button, that could be printed in the interface language as well, while a text field should be printed in the node language.
Comment #4
Gábor HojtsyTagging for the content handling leg of D8MI.
Comment #5
mgiffordWe're going to need a patch to look at for this. I know there have been a lot of changes in i18n in D8, but not sure if this is one of them.
Comment #6
leenwebb CreditAttribution: leenwebb commented(not an accessibility-specific issue, as far as Montreal Accessibility Sprint is concerned. Be sure to set the language attribute if you mix languages on a single page.)
Comment #7
PanchoDon't know what is correct. Think this should be postponed on #731724: Convert comment settings into a field to make them work with CMI and non-node entities as that will change about every line of comment module.
Also added this one to #1323338: [meta] Conform to WCAG Success Criterion 3.1.2: Language of Parts.
Comment #7.0
Pancho.
Comment #8
mgiffordOk, I think it is safe to change the status now.
Comment #17
pameeela CreditAttribution: pameeela commentedMarking this postponed until we have some steps to reproduce because these kinds of bugs are tricky enough with steps!
Any multilingual users know whether this is still valid and how to reproduce it?
Comment #21
quietone CreditAttribution: quietone at PreviousNext commentedI tested this on 9.5.x, standard install, with Italian as the second language and the article content type translatable. I tried without and then with comments translatable.
I was able to reproduce problems with the interface language when comments were not translatable. I added a comment on the Italian node and then the comment title was in Italian on both the English and the Italian versions of the node.
When comments were translatable things entering a comment on the Italian node always redirect to the English page on save. I think that is
#2751269: Submitting a comment in the non default language redirects you to the default language.
This also needs a new title.
Comment #23
Charles BelovThere is the separate issue now we have no control over what language the commenter uses when making their comment. I see comments in all sorts of languages on YouTube videos all on the same video and comments are not necessarily in the language of the video. In theory, all comment fields would correctly be accompanied by a way for the commenter to set the language of their comment; I realize this would be a feature request outside the scope of this issue. That said, it does point out the difficulty of solving this particular issue.