Add the comments property in entity_metadata_node_entity_property_info()

+++ b/modules/callbacks.inc
@@ -115,6 +115,16 @@ function entity_metadata_node_get_properties($node, array $options, $name, $enti
+ * Callback for getting node comments.

Let's better say "for getting the comments of a node".

+++ b/modules/node.info.inc
@@ -33,6 +33,12 @@ function entity_metadata_node_entity_property_info() {
+  $properties['comments'] = array(
+    'label' => t("Comments"),
+    'type' => 'list<comment>',
+    'description' => t("The node comments."),
+    'getter callback' => 'entity_metadata_node_get_comments',
+  );

What are the access restrictions for this property? I guess there is "access comments" or something like that.

Then, this needs to be provided by the comment module integration. Also, it's computed so we should set 'computed' to TRUE.

Still needs to be moved to comment module integration.

+++ b/modules/node.info.inc
@@ -33,6 +33,14 @@ function entity_metadata_node_entity_property_info() {
+    'access callback' => 'entity_metadata_comment_access',

That's an entity access callback, I doubt the arguments match.

Tagging according to #1832348: Add a computed property to load the comments of a node and #949372-4: Port issue views to Search API so we can have a performant backend.

@fago: any pointers in how to fix the access callback? I used the code in a hook_entity_property_info_alter(), without the access callback and it works perfectly (in our case).

I added this to prevent indexing unapproved comments:

  $select->fields('c', array('cid'))
    ->condition('c.nid', $entity->nid)
    ->condition('c.status', 1);

And this to mark the node for re-indexing after a commit has been submitted, or updated:

/**
 * Implements hook_comment_presave().
 *
 * Marks parent node for re-indexing.
 */
function MY_MODULE_comment_presave($comment) {
  search_api_track_item_change('node', array($comment->nid));
}

Tested the patch at #9, works fine for getting a related "comments" field for indexed nodes in search api. Works great, but I didn't test any access callbacks for comments because we don't have unapproved comments.

subscribe

#9: entity-add-comments-property-1414688-9.patch queued for re-testing.

I'm using patch #9 without problems to index comments in search api. I also did not test access issues.

Patch from #9 _plus_ latest 7.x-1.x-dev made our solr_search index comments.

We had to enable both 'Comments' from this patch and 'Comment: *' fields on admin/config/search/search_api/index/node_search/fields ... to have search result for comment strings the fields were added to our search views.

As we are now 1.5 years further I'm not sure we still need 'access callback'. Isn't that covered by entity.module $entity_info['comment']['access callback'] = 'entity_metadata_comment_access'; ?

Set to RTBC for another developers review.

I tried this out for #949372: Port issue views to Search API so we can have a performant backend and it looks good. We want to index the comment bodies.

(tag)

For Drupal.org, I had to go ahead and commit this to our deployment repository. We do want to get back to an unhacked module.

I created a simple module sandbox to integrate comments and node ...for me it works: https://drupal.org/sandbox/frankye/2066873

9: entity-add-comments-property-1414688-9.patch queued for re-testing.

Looks like the 7.x-1.x branch is not passing tests.

9: entity-add-comments-property-1414688-9.patch queued for re-testing.

Since the security issue for lists of referenced entities got fixed - time for this one. Thanks, committed!