#1418898: [META] Rewrite menu system

Patches in this issue do nothing more than rearranging stuff.

CommentFileSizeAuthor
#2 head-phase1.patch160.14 KBcasey
#1 navigation.patch200.45 KBcasey

Comments

casey’s picture

casey commented
Status: Active » Needs review
StatusFileSize
new navigation.patch200.45 KB

For easier review this patch only moves code into navigation.inc, router.inc could be a follow-up.

casey’s picture

casey commented
Title: Rewrite menu system; Step 1: Split code from menu.inc into navigation.inc and router.inc » Rewrite menu system; Phase 1: Split code from menu.inc into navigation.inc and router.inc
StatusFileSize
new head-phase1.patch160.14 KB

It's hard rebasing three stacked branches.

Split up menu.inc into
- router.inc, anything related to routing
- navigation.inc, navigation stuff minus menu trees
- menu.inc, menu trees

Next phase should make anything in navigation.inc to not rely on anything in menu.inc

thedavidmeister’s picture

thedavidmeister commented
Version: 8.x-dev » 9.x-dev
Status: Needs review » Closed (duplicate) 
error: patch failed: core/includes/common.inc:5060
error: core/includes/common.inc: patch does not apply
error: patch failed: core/includes/menu.inc:75
error: core/includes/menu.inc: patch does not apply

patch no longer applies.

considering where WSCCI is at currently, and how far from code freeze we are, is this issue still as relevant as it was in early 2012 or are its intentions a duplicate of that initiative?

I'm going to assume this can be closed as a duplicate, like its parent meta issue.

Feel free to re-open with a re-rolled patch against the current HEAD if you disagree.

thedavidmeister’s picture

thedavidmeister commented
Issue summary: View changes

small note about content of patches

Version: 9.x-dev » 9.0.x-dev

The 9.0.x branch will open for development soon, and the placeholder 9.x branch should no longer be used. Only issues that require a new major version should be filed against 9.0.x (for example, removing deprecated code or updating dependency major versions). New developments and disruptive changes that are allowed in a minor version should be filed against 8.9.x, and significant new features will be moved to 9.1.x at committer discretion. For more information see the Allowed changes during the Drupal 8 and 9 release cycles and the Drupal 9.0.0 release plan.