Could possibly be exposed as a local task and action. Would be nice to add this once file_access('download') lands.

CommentFileSizeAuthor
#5 1422260-5-file-download-callback.patch7.28 KBdevin carlson
#4 1422260-4-file-download-callback.patch3.96 KBdevin carlson
#3 1422260-3-file-download-callback.patch1.11 KBJackinloadup
#1 1422260-file-download-callback.patch1.07 KBdave reid

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
StatusFileSize
new 1422260-file-download-callback.patch1.07 KB
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

We should also implement a lot of the functionality in http://drupal.org/project/download_file. Should also trigger headers to cause the browser to trigger a download dialog rather than display the file in-browser.

Jackinloadup’s picture

Jackinloadup commented
StatusFileSize
new 1422260-3-file-download-callback.patch1.11 KB

Here is a reroll of the patch in #1 to work with the #1227706-78: Add a file entity access API for initial testing purposed. Full implementation still needed as stated in #2

devin carlson’s picture

devin carlson commented
Status: Postponed » Needs review
StatusFileSize
new 1422260-4-file-download-callback.patch3.96 KB

An updated patch to accommodate the changes required due to #1227706: Add a file entity access API and to add in the functionality provided by the DownloadFile module (along with an alter hook to allow other modules to modify the file download headers).

devin carlson’s picture

devin carlson commented
Assigned: dave reid » devin carlson
StatusFileSize
new 1422260-5-file-download-callback.patch7.28 KB

Rerolled and added test coverage.

ParisLiakos’s picture

ParisLiakos commented
Status: Needs review » Reviewed & tested by the community

awesome:)
i dont think we need something else here..i just checked this codewise and seems good to go
No manual testing but i trust devin did that already:)

bneil’s picture

bneil commented

I manually tested this and it works for me.

gmclelland’s picture

gmclelland commented

Just to verify, I did apply the patch in #5. I was able to receive a force download at file/49/download. I'm also seeing the new download permissions.

devin carlson’s picture

devin carlson commented
Status: Reviewed & tested by the community » Fixed

Committed to 7.x-1.x.

This is needed by CKEditor Link File to allow editors to easily link to file "downloads".

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.