Closed (won't fix)
Project:
Tagadelic
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
10 Feb 2012 at 07:56 UTC
Updated:
16 Feb 2013 at 08:18 UTC
Hi,
line 335
$output .= theme('more_link', array('title' => t('more tags'), 'url' => "tagadelic/chunk/{$vars['voc']->vid}"));
Patch with ->
if(isset($vars['voc'])){
if (count($terms) >= variable_get('tagadelic_block_tags_' . $vars['voc']->vid, 12)) {
$output .= theme('more_link', array('title' => t('more tags'), 'url' => "tagadelic/chunk/{$vars['voc']->vid}"));
}
return $output;
}
Comments
Comment #1
Bèr Kessels commentedIssues for tagadelic are closed on Drupal.org. Please provide a pull-request or ticket on Github
Thanks for reporting, though!
Comment #2
GlobalRaj commentedI know the status says "Won't fix" but that Github is too confusing for me. So I am posting my issue here hoping for some help.
The tags block is working fine but when I click on "More" I end up with error.
Thanks & Cheers!
Raj Padhi
Comment #3
GlobalRaj commentedAnd yes, if I apply the above mentioned patch, the error doesn't show up but nor do the tags.
When I click on "More" after applying the patch, I end up with the following.
I would just like to know if this one is being actively developed. If not, please let us know so I can just remove the module.
Thanks.
Raj Padhi
Comment #4
GlobalRaj commentedComment #5
leonardo.drupal commentedI know that this issue is closed but just posting this here so that it will be helpful to anyone who is still facing this problem.
See the original post but instead of patching with the code given in the post slightly modify it and replace the following (lines 334 and 335 of the tagadelic.module file)
with the following
Now you shouldn't get the error mentioned in #3
leo
Comment #6
WriteCo commentedThank you, Leo!
Comment #7
blglbrth commentedThank you Leo.
Comment #8
albertguedes commentedTanks leonardo.drupal , your tip work perfectly.
Comment #9
Bèr Kessels commentedPlease do not change the status!
Comment #10
hitesh-jain commentedThanks leo...........grt work
Comment #11
joverstreet commentedUsed #5 fix for the issue. Works great! Thanks Leo!
Comment #12
Triumphent commentedGreat fix Leo, thank you..! :)
Comment #13
kringf commentedThank you Leo, the fix works for me as well
Comment #14
raulmuroc commentedFor me is not working... the block just doesn't show anything at all. :S
Could someone pass me a tagadelic module zipped?? I tried everything and nothing works to raise up a tagged list.
Comment #15
Bèr Kessels commentedPlease do not change the status!
Comment #16
raulmuroc commentedOk... but anyway this is not working.
Comment #17
digibrill commentedGreat Leo!
Comment #18
objredline commentedI had all 4 errors on the /tagadelic page, Leo your code fixes it. Thanks!!!
Comment #19
Bèr Kessels commentedAs you all may, or may not know, this has long been fixed in the development-version over at https://github.com/berkes/tagadelic/commits/7.x-1.x
There are some other issues that need solving, because Leo's "patch" is but an ugly hack (Sorry Leo) and we'd rather fix this properly with a solid refactoring.
But, head over there, pick the latest if you feel adventurous. But you probably feel that anyway, since you all are using a unreleased, unstable and shipped-with-no-upgrade-paths module. But you probably already know why you should never run -dev releases in production.
Comment #20
jenlamptonCan we please get a stable version released on drupal.org ASAP, with an active issue queue here where people can participate?
Thanks :)
Comment #21
Bèr Kessels commentedIf you want a release, then please do not require my (precious) time by forcing me to administrate bugs that I have closed. That is counterproductive.
If you want a release, write code, send pull-requests, fix issues and whatnot.
Comment #22
HypervisedEd commentedI'm also having this error, its completely saturating my server's logs.
Since the developer of this module is clearly not interested in the development of Drupal can anyone recommend a similar module that is stable and is supported by someone who cares?
Comment #23
Bèr Kessels commentedTickets and bug-reports are not the right place for nasty remarks.
http://berk.es/2013/02/10/tagadelic-tdd-oop-and-seeking-maintainer/
I've been developing a new version for the last several months. Therefore your remark is not only wrong, it is nasty and completely out of place. FUD.
Comment #23.0
Bèr Kessels commentedadded code tags for sanity