Not able to create a site if the user is not associated to a client [#1439940]

Hi guys,

I've noticed that, even though the client feature is disabled, a normal user cannot create a site if it's not associated to any client. I tried with a new user and some basic permissions and what I get is a form_error saying:

Your user is not associated with any clients so you are not allowed to create new sites

I looked into the code and I tried to see if there's a fast solution to fix that, but then I noticed that the whole aegir platform is based on this client id (for instance the task queues are always empty for the user that is not associated to any client).

I think that this feature is great, but I'm afraid that right now if someone doesn't need it that is forced to use it. And the weird thing is when Aegir is installed this feature is disabled.

I'd like to help to patch it, but I think there's a lot of code involved.

Comments

Comment #1

ergonlogic

he/him

English

Montréal, Québec 🇨🇦

commented 25 May 2013 at 20:31

Status:

Active

» Closed (duplicate)

hosting_client is a dependency of hosting_site, and enabled on install. See #2004188: Feature reverse dependencies are not enforced, for follow-up on ensuring that this dependency relationship is enforced.

Comment #2

ergonlogic

he/him

English

Montréal, Québec 🇨🇦

commented 26 May 2013 at 04:12

Version:	6.x-1.6	» 6.x-1.x-dev
Status:	Closed (duplicate)	» Needs work

Actually, currently in our 1.x branch, hosting_client is not a declared dependency of hosting_site, when in fact it clearly is. Oddly, the 'Clients' hosting feature is listed under 'experimental' for some reason.

The easiest fix I can think of is to make hosting_client is a dependency of hosting_site. While we're at it, I think it'd be good to flag it HOSTING_FEATURE_REQUIRED (since it is), and move it our of 'experimental' (since it isn't).