[D7] Novalnet Payment Module-Invoice

You don't need to assign to yourself. Just leave as unassigned.
Also the link to your project page is this one: http://drupal.org/sandbox/Novalnet/1468642
The link to your git repo should be the public one: http://git.drupal.org/sandbox/Novalnet/1468642.git

A review of your module can be found here. It'd be a good idea to correct all the coding standards issues and then the module can be manually reviewed.

At a glance it looks as though most of the errors can be easily fixed.
Take a look at the report and try to fix the:

• indentations (2 spaces not a tab)
• info file: needs a description and core (which version of drupal core)
• When concatenating leave a space either side of the .
• If a line exceeds 80 characters it is usual standard to move to the next line

Hi

Good to see so much interest in the commerce module.

Manual review :

1) Clean your folder. You should only commit the commerce_novalnet module. It seems that you have commit much more : drupalcommerce_v_D_7.x-1.0_novalnet_v_1.0.1/site/all...

2) Clean you info
; Information added by drupal.org packaging script on 2012-02-05
12 version = "7.x-1.x-dev"
13 core = "7.x"
14 project = "commerce_novalnet"
15 datestamp = "1328400676"

3) use t() in order to enable your labels to be translated
109 'callback'=>'Pin By Callback(Telefon/Handy)',

4) what will be the name of your module commerce_novalnet_invoice or commerce_payment_novalnet_invoice ?

Automatic review :

There are still files other than README.txt in the master branch, make sure to remove them. See also step 5 in http://drupal.org/node/1127732
Review of the 7.x-1.x branch:

• README.txt is missing, see the guidelines for in-project documentation.
• ./drupalcommerce_v_D_7.x-1.0_novalnet_v_1.0.1/sites/all/modules/commerce_novalnet/modules/invoice/commerce_novalnet_invoice.module: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming
  

  function commerce_payment_novalnet_invoice_commerce_payment_method_info() {
  function commerce_payment_novalnet_invoice_submit_form_submit($payment_method, $pane_form, $pane_values, $order, $charge) {
  function commerce_payment_novalnet_invoice_transaction($payment_method,$parsed, $order, $charge, $name,&$data) {
  function commerce_payment_novalnet_invoice_getRealIpAddr() {
  

• Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

Cheers,

Get a review bonus and we will come back to your application sooner ;-)