While debugging #1322960: No support for PHP namespaces I ran across a PHP 5.2-only bug. It got me wondering what plans (if any) there are for migrating Drupal.org to PHP 5.3.

Known issues

Comments

webchick’s picture

Spoke to nnewton about this tonight. He says he's been pushing for this already, and believes the next step is just pushing the update to staging and see what breaks.

Crell’s picture

Did anything break?

drumm’s picture

stagingvm and scratchvm are still on 5.2.14 and 5.2.17

nnewton’s picture

Issue tags: +infrastructure, +drupal.org D7

re-tagging

nnewton’s picture

stagingwww/git7staging/git6staging updated

webchick’s picture

Title: PHP 5.3 upgrade plans? » Update prod to PHP 5.3
Priority: Normal » Critical

This was deployed to staging, but infrastructure team would like to leave it for a while to do more testing.

This is also an eventual blocker for the D7 upgrade (to ensure that our testing is against the same stuff), so raising to critical.

drumm’s picture

I noticed that short open tags (<? instead of <?php) are not allowed on staging. While we avoid them, they do happen, and we have other software that may not be as strict as us. I think our standard PHP configuration should allow them.

senpai’s picture

Assigned: Unassigned » nnewton
Issue tags: +sprint 3

Tagging for sprint 3.

skottler’s picture

@drumm, can you grep through staging to find all the short tag instances and post them here? Converting all of them to the regular tag style should be a really easy task. I am willing to help with the upgrade to 5.3 wherever I can be helpful, including converting short tags to normal tags :P

drumm’s picture

I haven't run into any other short open tags. This is hypothetical, but a big worry for me is 3rd party code. We do run other codebases, like CiviCRM and other libraries. We can't impose our coding standards on them. CiviCRM doesn't seem to use short open tags, but they do use more than 2 spaces of indentation.

senpai’s picture

It's my (possibly sole) opinion that unless we actually *have* third party code that we *know* uses short tags, there's no reason to account for the possibility within our DEV and TST environments. In this manner, we'll know quickly whether something we use has introduced short tags on purpose or by accident, and whether we want to go on using their stuff or write our own... (kidding on that last one)

cweagans’s picture

Status: Active » Fixed

This is done!

Crell’s picture

And there was much rejoicing!

nnewton’s picture

Status: Fixed » Active

Moving this back to active actually. While most things work, there are definitely warnings we need to track down.

Right now the webnodes are on 5.3 and util is on 5.2 still. I'm not going to update util to 5.3 until sam is around to help me debug any issues with the PHP git threads.

-N

senpai’s picture

Issue tags: +sprint 4, +sprint 5

Tagging for Sprint 5.

drumm’s picture

Issue summary: View changes

Add pift issue

drumm’s picture

Issue summary: View changes

More details

greggles’s picture

So, does that include the webserver where security.drupal.org runs? Because there are definite modue updates needed to get to 5.3 compliance on that site.

I appreciate the progress and don't want to slow it, but It would have been nice to get an email "this will happen on date X" before this change.

nnewton’s picture

@greggles, Yes it does. My apologies for not pinging you.

nnewton’s picture

Status: Active » Fixed

This is now fully done.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

gerhard killesreiter’s picture

Issue summary: View changes

even more details

Component: Webserver » Servers