Closed (fixed)
Project:
Drupal.org infrastructure
Component:
Servers
Priority:
Critical
Category:
Task
Assigned:
Reporter:
Created:
14 Mar 2012 at 01:03 UTC
Updated:
21 Aug 2014 at 21:00 UTC
Jump to comment: Most recent
While debugging #1322960: No support for PHP namespaces I ran across a PHP 5.2-only bug. It got me wondering what plans (if any) there are for migrating Drupal.org to PHP 5.3.
Known issues
Comments
Comment #1
webchickSpoke to nnewton about this tonight. He says he's been pushing for this already, and believes the next step is just pushing the update to staging and see what breaks.
Comment #2
Crell commentedDid anything break?
Comment #3
drummstagingvm and scratchvm are still on 5.2.14 and 5.2.17
Comment #4
nnewton commentedre-tagging
Comment #5
nnewton commentedstagingwww/git7staging/git6staging updated
Comment #6
webchickThis was deployed to staging, but infrastructure team would like to leave it for a while to do more testing.
This is also an eventual blocker for the D7 upgrade (to ensure that our testing is against the same stuff), so raising to critical.
Comment #7
drummI noticed that short open tags (
<?instead of<?php) are not allowed on staging. While we avoid them, they do happen, and we have other software that may not be as strict as us. I think our standard PHP configuration should allow them.Comment #8
senpai commentedTagging for sprint 3.
Comment #9
skottler commented@drumm, can you grep through staging to find all the short tag instances and post them here? Converting all of them to the regular tag style should be a really easy task. I am willing to help with the upgrade to 5.3 wherever I can be helpful, including converting short tags to normal tags :P
Comment #10
drummI haven't run into any other short open tags. This is hypothetical, but a big worry for me is 3rd party code. We do run other codebases, like CiviCRM and other libraries. We can't impose our coding standards on them. CiviCRM doesn't seem to use short open tags, but they do use more than 2 spaces of indentation.
Comment #11
senpai commentedIt's my (possibly sole) opinion that unless we actually *have* third party code that we *know* uses short tags, there's no reason to account for the possibility within our DEV and TST environments. In this manner, we'll know quickly whether something we use has introduced short tags on purpose or by accident, and whether we want to go on using their stuff or write our own... (kidding on that last one)
Comment #12
cweagansThis is done!
Comment #13
Crell commentedAnd there was much rejoicing!
Comment #14
nnewton commentedMoving this back to active actually. While most things work, there are definitely warnings we need to track down.
Right now the webnodes are on 5.3 and util is on 5.2 still. I'm not going to update util to 5.3 until sam is around to help me debug any issues with the PHP git threads.
-N
Comment #15
senpai commentedTagging for Sprint 5.
Comment #15.0
drummAdd pift issue
Comment #15.1
drummMore details
Comment #16
gregglesSo, does that include the webserver where security.drupal.org runs? Because there are definite modue updates needed to get to 5.3 compliance on that site.
I appreciate the progress and don't want to slow it, but It would have been nice to get an email "this will happen on date X" before this change.
Comment #17
nnewton commented@greggles, Yes it does. My apologies for not pinging you.
Comment #18
nnewton commentedThis is now fully done.
Comment #19.0
gerhard killesreiter commentedeven more details