Found couple of issues in FBSS comments ajax submission.

1.

Notice: Undefined index: #value in theme_textarea() (line 3732 of /home/***/public_html/includes/form.inc).

error on comment submission. added patch for it

2. After solving the above error, ajax comment submission is not updating the stream properly

Scenario 1
1. Enable statuses and statuses All block
2. Add a comment in statuses block
Expected Result : Both blocks should be updated with the new comment
Actual Result: Statuses block is updated, however its clearing the comments for the particular status in statuses All block

Scenario 2
1. Add a comment using the steps in scenario 1
2. Add another comment in statuses block
Expected Result : Both blocks should be updated with the new comment
Actual Result: statuses all block alone is getting updated, in stauses block nothing is happening.

In both scenarios the comment is successfully submitted.

CommentFileSizeAuthor
fbss-comments-ajax-submission-issue.patch650 bytesmathankumarc

Comments

icecreamyou’s picture

icecreamyou commented

Are you using the very latest build? I just committed some changes to the way comment AJAX submission works a few hours ago.

Also, FBSS/Statuses has never really claimed to support multiple status update forms on the same page, which includes not really supporting having two comment forms for the same status on the same page. I'm happy to accept a patch to support this, but I don't want to dig into the Form API internals enough myself. It's been awhile since I last looked into this but I remember it being pretty complicated, and the infrequency with which it comes up in the issue queue indicates to me that it's not a widely useful feature.

On a related note, you've been contributing a lot of patches lately -- thanks. If you'd like commit access to the repo, let me know.

mathankumarc’s picture

mathankumarc commented

Ya. I'm using the latest build only.

Will try to implement this feature.

mathankumarc’s picture

mathankumarc commented
Category: bug » feature
Status: Needs work » Active

Changing the category and status, since this is a feature request.

mathankumarc’s picture

mathankumarc commented

Can I go ahead and commit the patch? Because its blocking comments ajax submission.

icecreamyou’s picture

icecreamyou commented

Yeah, I tested this (albeit lightly) and I think it's fine.

mathankumarc’s picture

mathankumarc commented
Status: Active » Postponed

Committed a fix to dev for comments ajax submission issue.

Postponing the issue, since we need give the priority to the submodule integrations first.