http://drupal.org/project/gravatar

CommentFileSizeAuthor
#2 1484722.patch4.34 KBRobLoach
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Michelle’s picture

Michelle
she/her
Primary language English
Location Wisconsin, USA
CreditAttribution: Michelle commented

Uh... Could you give some more info there? :) Is there something broken with the gravatar support?

RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented
Status: Active » Needs work
FileSize
1484722.patch4.34 KB

Sorry about that. Didn't really have the time to put together a proper issue summary at the time.

The problem is regression from Author Pane implementing its own Author Pane User Profile templating instead of overriding template_preprocess_user_picture(). When Gravatar was installed, it wouldn't use the Gravatar profile image, as Author Pane did its own stuff for the avatar. Although I've only had a quick look, the attached patch is headed in the right direction. With this patch, it uses Drupal's user picture templating, so Gravatar is still a consideration.

Probably needs more testing before committing it.

Michelle’s picture

Michelle
she/her
Primary language English
Location Wisconsin, USA
CreditAttribution: Michelle commented

Hmm... I could have sworn I added Gravatar support in D6. Keep in mind that Author Pane intentionally uses its own method for images because it's doing something slightly different than core (linking to the larger profile image as you'd expect rather than the redundant link to the profile page).

I'm on a plane this afternoon so can't look at this any more right now, sorry.

RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented

Yup! This still supports different image sizes as it only overrides if $variables['caller'] is set. But again, this probably still needs testing. Thanks Michelle! :-) ... See you next week!