If the website uses jquery.ui's auto-complete then this module breaks that code. I have attached 2 patches that when applied will fix the problem.

CommentFileSizeAuthor
#7 apachesolr_autocomplete-1491068-D6.patch1.09 KBjanusman
#2 1491068-jquery-autocomplete-collision-fix.patch1.19 KBjanusman
2.patch383 bytesDaemon_Byte
1.patch121 bytesDaemon_Byte

Comments

janusman’s picture

janusman commented

Nice catch. This needs a proper patch (some patch instructions here) . I'll roll a new one soon.

janusman’s picture

janusman commented
StatusFileSize
new 1491068-jquery-autocomplete-collision-fix.patch1.19 KB

New patch. This would also need backporting to 6.x.

On a more general note, should we rather look at using jquery.ui's autocomplete? Why or why not?

Daemon_Byte’s picture

Daemon_Byte commented

Thanks for putting that into a proper patch. I really must get around to getting git sorted for that. I guess using the latest jquery's ui auto-complete would make long term sense but I don't know what affects that will have

selvamkf’s picture

selvamkf commented

Infact I had to make this module to use jquery.ui instead of the old autocomplete plugin. But it is by altering the js by a custom module. If you think, I can help in converting this module to use jquery.ui, let me know. I would also like to tell you that limiting search to only node title can be done (using a config option) which I have already done.

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
Status: Needs review » Reviewed & tested by the community

Working properly. Thanks. Please commit this

janusman’s picture

janusman commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

@selvamkf: I'd be very interested in the custom code you wrote.

For now, I have committed the patches from #2 as they seem to get rid of the problem.

Now pending patch for 6.x-1.x if anyone's interested. =)

janusman’s picture

janusman commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new apachesolr_autocomplete-1491068-D6.patch1.09 KB

Patch for 6.x-1.x

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented

Do I spot a tab here in the patch?

janusman’s picture

janusman commented

Yes. This was originally a jQuery plugin from http://bassistance.de/jquery-plugins/jquery-plugin-autocomplete/ ... which looks to have been forked since at https://github.com/agarzola/jQueryAutocompletePlugin

So I will probably keep the tabs since the rest of the file has tabs as well, just for consistency :) Later on I should probably convert all tabs to spaces since this is basically another fork of that.

kleinmp’s picture

kleinmp commented

This is an issue in 7.x-1.x-dev too. The patch in comment 7 above fixes it there too, but since Drupal 7 comes shipped with jquery ui autocompete, maybe it would be good to use the jqueri ui autocomplete instead.

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented

Doesn't seem to be committed?

janusman’s picture

janusman commented
Issue summary: View changes
Status: Needs review » Active

Committed to 7.x-1.x.

Awaiting commit to 6.x-1.x

  • 6209749 committed on 7.x-1.x 
    Fix #1491068 by @Daemon_Byte: incompatible with jquery.ui autocomplete