Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.If the website uses jquery.ui's auto-complete then this module breaks that code. I have attached 2 patches that when applied will fix the problem.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | apachesolr_autocomplete-1491068-D6.patch | 1.09 KB | janusman |
| #2 | 1491068-jquery-autocomplete-collision-fix.patch | 1.19 KB | janusman |
| 2.patch | 383 bytes | Daemon_Byte | |
| 1.patch | 121 bytes | Daemon_Byte |
Comments
Comment #1
janusman commentedNice catch. This needs a proper patch (some patch instructions here) . I'll roll a new one soon.
Comment #2
janusman commentedNew patch. This would also need backporting to 6.x.
On a more general note, should we rather look at using jquery.ui's autocomplete? Why or why not?
Comment #3
Daemon_Byte commentedThanks for putting that into a proper patch. I really must get around to getting git sorted for that. I guess using the latest jquery's ui auto-complete would make long term sense but I don't know what affects that will have
Comment #4
selvamkf commentedInfact I had to make this module to use jquery.ui instead of the old autocomplete plugin. But it is by altering the js by a custom module. If you think, I can help in converting this module to use jquery.ui, let me know. I would also like to tell you that limiting search to only node title can be done (using a config option) which I have already done.
Comment #5
nick_vhWorking properly. Thanks. Please commit this
Comment #6
janusman commented@selvamkf: I'd be very interested in the custom code you wrote.
For now, I have committed the patches from #2 as they seem to get rid of the problem.
Now pending patch for 6.x-1.x if anyone's interested. =)
Comment #7
janusman commentedPatch for 6.x-1.x
Comment #8
nick_vhDo I spot a tab here in the patch?
Comment #9
janusman commentedYes. This was originally a jQuery plugin from http://bassistance.de/jquery-plugins/jquery-plugin-autocomplete/ ... which looks to have been forked since at https://github.com/agarzola/jQueryAutocompletePlugin
So I will probably keep the tabs since the rest of the file has tabs as well, just for consistency :) Later on I should probably convert all tabs to spaces since this is basically another fork of that.
Comment #10
kleinmp commentedThis is an issue in 7.x-1.x-dev too. The patch in comment 7 above fixes it there too, but since Drupal 7 comes shipped with jquery ui autocompete, maybe it would be good to use the jqueri ui autocomplete instead.
Comment #11
nick_vhDoesn't seem to be committed?
Comment #12
janusman commentedCommitted to 7.x-1.x.
Awaiting commit to 6.x-1.x