Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The generated query is not checking for active users, this is critical.
Find attached in the next comment
Comment | File | Size | Author |
---|---|---|---|
#15 | privatemsg-check_if_active-1509436-15.patch | 1.03 KB | adnasa |
#12 | privatemsg-check_active-1509436-12.patch | 1.03 KB | adnasa |
#7 | privatemsg-check_active-1509436-7.patch | 1.15 KB | paolomainardi |
#5 | privatemsg-check_active-1509436-3.patch | 1.15 KB | paolomainardi |
#3 | privatemsg-check_active-1509436-2.patch | 1.18 KB | paolomainardi |
Comments
Comment #1
paolomainardi CreditAttribution: paolomainardi commentedComment #3
paolomainardi CreditAttribution: paolomainardi commentedSorry this is the correct one.
Comment #5
paolomainardi CreditAttribution: paolomainardi commentedSorry, i forgot to add --relative to git diff.
Comment #7
paolomainardi CreditAttribution: paolomainardi commentedTrying to use a relative path starting from module root.
Comment #8
BerdirComment #10
BerdirThe patch needs to be created from the root of the *project*, not the module. Meaning, the path needs to be like a/privatemsg_roles/privatemsg_roles.module.
Comment #11
BerdirComment #12
adnasa CreditAttribution: adnasa commentedone more time.
Comment #14
Berdirneeds to be u.uid.
Comment #15
adnasa CreditAttribution: adnasa commentedthank you for the feedback,
double checked and this should be fine.
Comment #17
paolomainardi CreditAttribution: paolomainardi commentedHi Berdir, sorry for delay, i didn't have much time. Thanks adnana for submitting the updated patch.
Comment #18
adnasa CreditAttribution: adnasa commentedI've failed though :-(
I don't fully understand the test suite.
will study more before I continue submitting patches.
Comment #19
Berdir#15: privatemsg-check_if_active-1509436-15.patch queued for re-testing.
Comment #21
ptmkenny CreditAttribution: ptmkenny commentedThis was fixed in 7.x and is now a candidate for backport here: https://drupal.org/node/834706