Closed (fixed)
Project:
Hosting
Version:
6.x-2.x-dev
Component:
Views integration
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
4 Apr 2012 at 18:37 UTC
Updated:
12 Jun 2014 at 08:59 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
omar commentedA piece of a screencapture ...
Comment #2
omega8cc commentedIt looks great! But please follow Aegir standards and rename it to
hosting_package_use.Comment #3
Robin Millette commentedI didn't want to patch aegir right away, but my thought was this single nodeapi hook could probably live in another module, instead of living on its own, no?
I also added a couple issues to the sandbox: #1515540: Show only sites and platforms accessible by the user and #1515532: Pager not working.
Comment #4
anarcat commentedI think this is a great candidate for core itself, i don't see why it should be a separate module. Please work on patching the existing core if you have time, that would be great!
The pager doesn't seem like a big deal, but this would be a blocker however: #1515540: Show only sites and platforms accessible by the user.
Thanks for your contribution!
Comment #5
Robin Millette commentedGreat! Going to submit a patch soonish.
I would appreciate some direction with regards to #1515540: Show only sites and platforms accessible by the user. My use of aegir is very "one client" centric. Come to think of it, Client is actually a module that could be enabled or not. If you have any tips for me, please elaborate in #1515540: Show only sites and platforms accessible by the user. Just posting here to get your attention.
Comment #6
helmo commentedGreat I would love to see this in Aegir.
This relates somewhat to: #1000368: Provide module version/install status across platforms
Comment #7
Robin Millette commentedI'm not currently working on this. If somebody wants to jump in, please!
Comment #8
helmo commentedHere's a patch host hostmaster core.
* I've removed the ClientID column, as I don't really see a good use for it. Or it whould have to be turned into a nice link.
* Added a clear:both css style to prevent the list from overlapping with the task queue in Firefox.
Comment #9
helmo commentedSetting the correct version branch
Comment #10
helmo commentedI've added an extra WHERE clause to the query.
It now filters out information about deleted sites.
One other thought is that maybe we should check hosting_platform_client_access. This could be done with the code below, but I doubt that a regular client would access this page.
Comment #11
helmo commentedOne other nice to have, but way out of scope here, would be to have info on site specific packages in the hostmaster database. Currently only packages from the platform are loaded in the hostmaster database.
Comment #12
helmo commentedTested with 6.x-2.0-alpha1, works OK.
Comment #13
omega8cc commentedWe are using it (the patch) in BOA for a long time already, however there is something to improve, I think, because it shows usage also for deleted sites - see the screenshot.
Comment #14
omega8cc commentedOh, maybe we are using that older patch then? I will check that again.
Comment #15
omega8cc commentedOf course we have applied that older patch, sorry for the noise!
It is RTBC already.
Comment #16
anarcat commentedpatch doesn't apply anymore, sorry!
@omega8 - can you pinpoint a commit or branch we can merge?
Comment #17
helmo commentedIt seems to be just some lines that have shifted.
Patch -F1000 works wonders for these cases ;)
Comment #18
anarcat commentedaah the fuzz, i always forget about the fuzz. -F3 was enough, even ;)
thanks!
Comment #20
ergonlogicAfter the Views integration, I believe we have lost this functionality. Either way, we should look at re-implementing it in Views. Since we're already doing this for install profile packages, hopefully it won't be too difficult.
Comment #21
helmo commentedOK, so this if in package/hosting_package.module:284 just kills it:
It was probably intended as:
The view hosting_site_list is also shown for both modules and profiles. But only shows something for profiles.
What I'm missing there though is the package version info. Do we have views integration for the package instances?
ref: #588728: Meta: Views integration redux
Comment #22
helmo commentedI've re-opened #1876358: Convert list of packages to use views and posted a second issue #2019631: Views handler for package versions not numeric
Comment #23
anarcat commentedwait, that means we can close this issue already. :)
Comment #24
helmo commentedNo, sorry but #22 was extra. #20 and #21 are not resolved.
I think we need an extra view for this. One that takes a package as the basis, listing all sites that have the package enabled, with their respective version.
The current path: node/% (for packages)
Comment #25
decipheredWill take a look at this issue tomorrow.
Comment #26
decipheredPretty simple view + Upgrade path:
Repo: http://drupalcode.org/sandbox/deciphered/2001932.git/shortlog/refs/heads...
Patch: http://drupalcode.org/sandbox/deciphered/2001932.git/patch/11bf084681546...
Comment #27
helmo commentedThanks.
I'd like to filter Disabled modules by default. This patch adds an exposed filter...
One strange thing... in views_handler_field_hosting_package_status.inc we render t('Enabled') : t('Disabled'). Where do we need to declare that to also have it for the exposed filter?
Comment #28
ergonlogicFixed in dd1995c (hostmaster) and 4f6297b (hosting).