Recent Update

Automated Review

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:

• Remove "version" from the info file, it will be added by drupal.org packaging automatically.
• Remove "project" from the info file, it will be added by drupal.org packaging automatically.
• Remove all old CVS $Id tags, they are not needed anymore.
  

  recent_update.info:1:; $Id: yogiloka.info,v 1.0 2007/06/23 11:15:48 snpower Exp $
  recent_update.module:2:// $Id: recent_update.module,v 1.1 2009/06/23 11:15 
  

• Drupal Code Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

Manual Review

recent_update_menu
- Your menu item calls the function recent_update_form_setting which then just calls drupal_get_form. Instead your menu item should call 'drupal_get_form' as the page callback, and the page arguments should just be array('recent_update_form')

recent_update_form
- You should have all your form fields titles and descriptions enclosed in t() for translations. Don't include HTML in the t() call though.

recent_update_form_validate
- Your form_set_error's message should be enclosed in t()

recent_update_form_submit
- Rather than doing your own check to see if you need to insert or update, instead use db_merge()
- drupal_set_message's message should be enclosed in t()

recent_update_contents
- You hardcode a link to your site. Other users of your module probably don't want this.

recent_update_last_updated
- You never set the cache value of recent_update_last_updated, as when you set the date to the cache, you're setting it as mymodule_last_updated

Hi,

Is it possible to add some more information to your project page and this ? (and with more structure ?)

For example :
Overview
Bugs
Requirements
Installation
Screenshots

...

Thanks.

Closing due to lack of activity. Feel free to reopen if you are still working on this application.