Errors when enabling flag submodules for status module

Duplicate of #1296238: calls to flag_get_flag('follow')->fid or ->status fail

You need to use the latest dev version for flag integration.

Can we create another checkpoint release?

This has already been fixed in dev.

EDIT: cross-post. Since we're so close to an alpha release no need to create another checkpoint release.

Also if an issue is closed before I comment on it I probably won't notice it so if you need my feedback just drop me an email or something.

This is a duplicate of #1427788: Trying to get property of non-object in fbss_flag_views_default_views() (line 22 not #1296238: calls to flag_get_flag('follow')->fid or ->status fail

1. Go to admin/modules
2. Un-check the box next to the modules you want to uninstall and submit the form
3. Go to admin/modules/uninstall
4. Check the box next to the modules you want to uninstall and submit the form
5. Delete the module from your modules directory
6. Download the dev version of the module and upload it to your modules directory
7. Enable the modules you want

Generally you can skip the install/uninstall steps and just delete the old version and upload the new version. If you do that make sure to run update.php afterwards. Make sure you actually do delete the whole module folder though, if you just overwrite it you could end up with problems.

Strict warning: Declaration of fbss_flag::replace_tokens() should be compatible with that of flag_flag::replace_tokens() in require_once() (line 20 of C:\_BACKUPS\DrupalCore7.12\drupal-7.12\sites\all\modules\statuses\submodules\fbss_flag\fbss_flag.flag.inc).

yeah replace_tokens is changed in flag api 2. I think we need to revisit the flag integration again.

Can we reopen #1296238: calls to flag_get_flag('follow')->fid or ->status fail or use this issue to fix the flag integration.

Notice: Undefined property: flag_heartbeat_message::$status in fbss_flag_views_default_views_alter() (line 68 of C:\_BACKUPS\DrupalCore7.12\drupal-7.12\sites\all\modules\statuses\submodules\fbss_flag\fbss_flag.module).

I'm not able to reproduce this one

Can we reopen #1296238: calls to flag_get_flag('follow')->fid or ->status fail or use this issue to fix the flag integration.

This issue is fine

I dunno whether these functions are deprecated, I'm not seeing this flag_flag class

• applies_to_content_id_array()
• rules_get_event_arguments_definition()
• rules_get_element_argument_definition()

oops missed the patch.

Well I haven't tested it but #10 doesn't introduce any breaking changes so if that fixes things that's fine

I didnt tested this one. just modified the function definitions according to new api changes. If someone confirm this then its RTBC.

I didnt tested this one. just modified the function definitions according to new api changes. If someone confirm this then its RTBC.

Edit : Duplicate comments :(

@oystercrackher
Thanks for your report.

seems to be flag integration needs more care. Will fix this in this weekend :)

I too am getting this error when enabling the Statuses Flags module (error shown on Modules page):

Notice: Undefined property: flag_heartbeat_message::$status in fbss_flag_views_default_views_alter() (line 68 of /home/account/public_html/drupal/sites/all/modules/statuses/submodules/fbss_flag/fbss_flag.module).

Since I've other priorities I cant specify a eta for this one. But this will be fixed before alpha 1 release as Isaac mentioned in #1551542: [META] Release Plan

Strict warning: Only variables should be passed by reference in statuses_views_handler_argument_flagged_user->option_definition() (line 15 of C:\_BACKUPS\DrupalCore7.12\drupal-7.12\sites\all\modules\statuses\submodules\fbss_flag\views\statuses_views_handler_argument_flagged_user.inc).
•Strict warning: Only variables should be passed by reference in statuses_views_handler_argument_flagged_user->option_definition() (line 15 of C:\_BACKUPS\DrupalCore7.12\drupal-7.12\sites\all\modules\statuses\submodules\fbss_flag\views\statuses_views_handler_argument_flagged_user.inc).

I'm not getting this error. I fixed other issues.

I know some of these have been posted and probably wont help after the updated dev is done but here is what I am currently getting with the latest dev version and

Strict warning: Declaration of fbss_comments_flag::replace_tokens() should be compatible with that of flag_flag::replace_tokens() in module_load_include() (line 302 of C:\xampp\htdocs\d7\includes\module.inc).

Strict warning: Declaration of fbss_flag::replace_tokens() should be compatible with that of flag_flag::replace_tokens() in module_load_include() (line 302 of C:\xampp\htdocs\d7\includes\module.inc).

Strict warning: Declaration of fbsmp_views_handler_field_themed_attachment::init() should be compatible with that of views_handler_field::init() in _registry_check_code() (line 3046 of C:\xampp\htdocs\d7\includes\bootstrap.inc).

Strict warning: Declaration of statuses_views_handler_argument_flagged_user::query() should be compatible with that of views_handler_argument::query() in _registry_check_code() (line 3046 of C:\xampp\htdocs\d7\includes\bootstrap.inc).

Strict warning: Only variables should be passed by reference in statuses_views_handler_argument_flagged_user->option_definition() (line 15 of C:\xampp\htdocs\d7\sites\all\modules\statuses\submodules\fbss_flag\views\statuses_views_handler_argument_flagged_user.inc).

Strict warning: Only variables should be passed by reference in statuses_views_handler_argument_flagged_user->option_definition() (line 15 of C:\xampp\htdocs\d7\sites\all\modules\statuses\submodules\fbss_flag\views\statuses_views_handler_argument_flagged_user.inc).

Strict warning: Only variables should be passed by reference in statuses_views_handler_argument_flagged_user->option_definition() (line 15 of C:\xampp\htdocs\d7\sites\all\modules\statuses\submodules\fbss_flag\views\statuses_views_handler_argument_flagged_user.inc).

Strict warning: Only variables should be passed by reference in statuses_views_handler_argument_flagged_user->option_definition() (line 15 of C:\xampp\htdocs\d7\sites\all\modules\statuses\submodules\fbss_flag\views\statuses_views_handler_argument_flagged_user.inc).

Strict warning: Only variables should be passed by reference in statuses_views_handler_argument_flagged_user->option_definition() (line 15 of C:\xampp\htdocs\d7\sites\all\modules\statuses\submodules\fbss_flag\views\statuses_views_handler_argument_flagged_user.inc).

Strict warning: Only variables should be passed by reference in statuses_views_handler_argument_flagged_user->option_definition() (line 15 of C:\xampp\htdocs\d7\sites\all\modules\statuses\submodules\fbss_flag\views\statuses_views_handler_argument_flagged_user.inc).

Strict warning: Declaration of fbss_comments_flag::replace_tokens() should be compatible with that of flag_flag::replace_tokens() in module_load_include() (line 302 of C:\xampp\htdocs\d7\includes\module.inc).

Strict warning: Declaration of fbss_flag::replace_tokens() should be compatible with that of flag_flag::replace_tokens() in module_load_include() (line 302 of C:\xampp\htdocs\d7\includes\module.inc).


Strict warning: Declaration of fbss_comments_flag::replace_tokens() should be compatible with that of flag_flag::replace_tokens() in module_load_include() (line 302 of C:\xampp\htdocs\d7\includes\module.inc).

Strict warning: Declaration of fbss_flag::replace_tokens() should be compatible with that of flag_flag::replace_tokens() in module_load_include() (line 302 of C:\xampp\htdocs\d7\includes\module.inc).

//I dont think this one has been posted yet.
Notice: Undefined property: flag_broken::$status in fbss_flag_views_default_views_alter() (line 68 of C:\xampp\htdocs\d7\sites\all\modules\statuses\submodules\fbss_flag\fbss_flag.module).

Strict warning: Declaration of fbsmp_views_handler_field_themed_attachment::init() should be compatible with that of views_handler_field::init() in _registry_check_code() (line 3024 of C:\xampp\htdocs\d7\includes\bootstrap.inc).

And then I get these additional errors when posting a image using FBSMP.

Strict warning: Declaration of fbss_comments_flag::replace_tokens() should be compatible with that of flag_flag::replace_tokens() in module_load_include() (line 302 of C:\xampp\htdocs\d7\includes\module.inc).

Strict warning: Declaration of fbss_flag::replace_tokens() should be compatible with that of flag_flag::replace_tokens() in module_load_include() (line 302 of C:\xampp\htdocs\d7\includes\module.inc).

Im using the latest dev version of Statuses, flags, views and ctools

oops. just now I noticed that I didnt enabled E_STRICT error reporting. thats why I'm unable to reproduce some errors.

Re #21 : These errors are already been reported

Strict warning: Declaration of fbsmp_views_handler_field_themed_attachment::init() should be compatible with that of views_handler_field::init() in _registry_check_code() (line 3024 of C:\xampp\htdocs\d7\includes\bootstrap.inc).

This is not related to this issue queue. this issue should be reported in FBSMP module issue queue. However committed a fix to dev for this issue in fbsmp 7.x branch.

Hereafter post the issues in proper issue queues.

Finally got it. Fixed all the errors and warnings.

Any testers?

+++ b/submodules/fbss_flag/views/statuses_views_handler_argument_flagged_user.incundefined
@@ -11,8 +11,9 @@
-    $content_type = 'statuses';
-    $flag = array_shift(flag_get_flags($content_type));
+    $content_type = 'user';
+    $flags = flag_get_flags($content_type);

But I have a question regarding this one. I think $content_type should be user not statuses, cause in options_form we are listing the user content type flags not statuses content_type flags.

If this is the case, then we need to backport this change.

I would like to try this but im currently having a problem with the patching the patch on the module...

@hiddenfellon

this may help you
http://drupal.org/project/statuses/git-instructions

Works like a charm, remember to put the patch in the root statuses file before patching people. =)

Re #23: you're right, good catch. Other than that this is RTBC.

(Sorry I've been AFK, busy at work.)

No problem.

Committed to 7.x
Here is the patch for 6.x

I'm getting another bunch of warnings in other submodule handlers after enabling E_STRICT warnings. Need consider them as followup issue.

#1501978: Create an upgrade path from Facebook-style Statuses (D6) this alone is pending for alpha release. I'm really afraid to take this one :( Any way will give a try :)

I have some time this afternoon, will commit this to D6 and work on the upgrade issue.

Committed to D6. Marking this fixed, but let's make sure to follow up with other E_STRICT warnings.

@oystercrackher: I can't reproduce the issue you're describing. Please open a separate support request and reference any related issues.