From reviewing other issues, it is my understanding that the comments should work like this: a) when there are no comments, the comment field is hidden, until the "comment" link is clicked, revealing the form and button, and that b) when there are comments, the field is visible beneath the comments and autogrow can be used to keep it unobtrusive until text is entered.

On my installation, the comment field and submit button appear beneath every status update, whether there are already comments or not.

Is this by design or a bug?

I've used FBSS on a D6 install, and preferred that clicking "comment" revealed a comment field and button. This is the functionality that I'd like to keep.

Thanks for the help!

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

IceCreamYou’s picture

You are correct about how this is supposed to work and this is a bug.

madgib’s picture

Is there anything I can provide to help troubleshoot?

IceCreamYou’s picture

This is unlikely to be a complicated problem, and since I can reproduce it, it won't be hard to debug. This mainly just requires time from one of the maintainers to confirm and commit a fix.

mathankumarc’s picture

@Isaac
will look into it.

mathankumarc’s picture

Status: Active » Needs review
FileSize
7.91 KB

Here is the patch.

And I need some clarification regarding the follwing comment in fbss_comments.module

/**
 * Displays the status comment form.
 *
 * @param $sid
 *   The Status ID of the comment thread.
 * @param $delay_load_form
 *   If TRUE and there are no comments on the relevant status, a "comment" link
 *   will be displayed instead of the comment form. When clicked, the form will
 *   be revealed for users with JavaScript enabled. Users with JavaScript
 *   disabled will be redirected to the status thread page. If FALSE the
 *   "comment" link will not be used and the comment form will not be initially
 *   hidden.
 * @param $delay_load_comments
 *   If TRUE and there are no comments on the relevant status, a "show all
 *   comments" link will be displayed instead of the full list of comments. When
 *   clicked, the full list of comments will be shown for users with JavaScript
 *   enabled. Users with JavaScript disabled will be redirected to the status
 *   thread page. If FALSE the "comment" link (with the comment form hidden)
 *   will be used instead of just showing the comment form.
 * @return
 *   The themed HTML for the status form, or if the user does not have
 *   permission to post a comment, then the list of comments.
 */
@param $delay_load_comments
If TRUE and there are no comments on the relevant status, a "show all comments" link will be displayed instead of the full list of comments

If there is no comment why we need to show "show all comments" link? Correct me If I'm wrong.

IceCreamYou’s picture

Status: Needs review » Fixed

The comment was wrong. I committed the patch to dev along with a fix for the docs. Also fixed the d.o documentation. Thanks

mathankumarc’s picture

Status: Fixed » Needs work

I think the comment change should be back ported.

IceCreamYou’s picture

Status: Needs work » Fixed

True, committed

madgib’s picture

Status: Fixed » Active

Thanks for addressing this quickly - much appreciated. The "Statuses" block now works correctly, but the original problem still exists with the "Statuses: all statuses". Thanks!

mathankumarc’s picture

Status: Active » Postponed (maintainer needs more info)

I'm not able to re-produce this. Its perfectly working for me.

IceCreamYou’s picture

@madgib -- you may need to flush your caches

BeaPower’s picture

Has this been committed to the recent dev because I dont see any changes... still doesnt appear.

mathankumarc’s picture

@BeaPower
yeah its already committed to dev. here is the commit log.

BeaPower’s picture

I did refresh, but still dont see the comment box.

mathankumarc’s picture

as mentioned in issue description,

  • If the status doesn't have any comments, then "comment" link will be provided, clicking on the link will display the comment box
  • If the status has one or more comment, comment box will displayed directly

Did you verified above scenarios?

madgib’s picture

Status: Postponed (maintainer needs more info) » Fixed

@beapower - did you flush both the Drupal's cache and your browser cache since? In my case, it was remembering the old javascript.

@mathankumarc and @IceCreamYou - You're right, it must have been a cache issue. Coming back to my site after some time away, and everything appears to work as expected. Thanks!

mathankumarc’s picture

@madgip thanks for reporting back.

Title: Comment field always visible » Comment about 307 status code is incorrect.
Project: Statuses (Social Microblog) » Drupal core
Version: 7.x-1.x-dev » 7.3
Component: Comments submodule » cron system
Status: Fixed » Needs work
Issue tags: +Needs backport to D6, +Needs backport to D7

The last submitted patch, comment-field-display-issue-1534266-5.patch, failed testing.

mathankumarc’s picture

What's happening here? Why this is moved to core issue queue?

mathankumarc’s picture

Created a new issue in Drupal.org Testbots issue queue regarding this #1577350: Bot moving other module's issues to Drupal core issue queue

mathankumarc’s picture

Title: Comment about 307 status code is incorrect. » Comment field always visible
Project: Drupal core » Statuses (Social Microblog)
Version: 7.3 » 7.x-1.x-dev
Component: cron system » Comments submodule
Status: Needs work » Fixed
Issue tags: -Needs backport to D6, -Needs backport to D7

Moving back to Statuses (Social Microblog) issue queue.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.