From reviewing other issues, it is my understanding that the comments should work like this: a) when there are no comments, the comment field is hidden, until the "comment" link is clicked, revealing the form and button, and that b) when there are comments, the field is visible beneath the comments and autogrow can be used to keep it unobtrusive until text is entered.
On my installation, the comment field and submit button appear beneath every status update, whether there are already comments or not.
Is this by design or a bug?
I've used FBSS on a D6 install, and preferred that clicking "comment" revealed a comment field and button. This is the functionality that I'd like to keep.
Thanks for the help!
Comment | File | Size | Author |
---|---|---|---|
#5 | comment-field-display-issue-1534266-5.patch | 7.91 KB | mathankumarc |
Comments
Comment #1
IceCreamYou CreditAttribution: IceCreamYou commentedYou are correct about how this is supposed to work and this is a bug.
Comment #2
madgib CreditAttribution: madgib commentedIs there anything I can provide to help troubleshoot?
Comment #3
IceCreamYou CreditAttribution: IceCreamYou commentedThis is unlikely to be a complicated problem, and since I can reproduce it, it won't be hard to debug. This mainly just requires time from one of the maintainers to confirm and commit a fix.
Comment #4
mathankumarc CreditAttribution: mathankumarc commented@Isaac
will look into it.
Comment #5
mathankumarc CreditAttribution: mathankumarc commentedHere is the patch.
And I need some clarification regarding the follwing comment in fbss_comments.module
If there is no comment why we need to show "show all comments" link? Correct me If I'm wrong.
Comment #6
IceCreamYou CreditAttribution: IceCreamYou commentedThe comment was wrong. I committed the patch to dev along with a fix for the docs. Also fixed the d.o documentation. Thanks
Comment #7
mathankumarc CreditAttribution: mathankumarc commentedI think the comment change should be back ported.
Comment #8
IceCreamYou CreditAttribution: IceCreamYou commentedTrue, committed
Comment #9
madgib CreditAttribution: madgib commentedThanks for addressing this quickly - much appreciated. The "Statuses" block now works correctly, but the original problem still exists with the "Statuses: all statuses". Thanks!
Comment #10
mathankumarc CreditAttribution: mathankumarc commentedI'm not able to re-produce this. Its perfectly working for me.
Comment #11
IceCreamYou CreditAttribution: IceCreamYou commented@madgib -- you may need to flush your caches
Comment #12
BeaPower CreditAttribution: BeaPower commentedHas this been committed to the recent dev because I dont see any changes... still doesnt appear.
Comment #13
mathankumarc CreditAttribution: mathankumarc commented@BeaPower
yeah its already committed to dev. here is the commit log.
Comment #14
BeaPower CreditAttribution: BeaPower commentedI did refresh, but still dont see the comment box.
Comment #15
mathankumarc CreditAttribution: mathankumarc commentedas mentioned in issue description,
Did you verified above scenarios?
Comment #16
madgib CreditAttribution: madgib commented@beapower - did you flush both the Drupal's cache and your browser cache since? In my case, it was remembering the old javascript.
@mathankumarc and @IceCreamYou - You're right, it must have been a cache issue. Coming back to my site after some time away, and everything appears to work as expected. Thanks!
Comment #17
mathankumarc CreditAttribution: mathankumarc commented@madgip thanks for reporting back.
Comment #21
mathankumarc CreditAttribution: mathankumarc commentedWhat's happening here? Why this is moved to core issue queue?
Comment #22
mathankumarc CreditAttribution: mathankumarc commentedCreated a new issue in Drupal.org Testbots issue queue regarding this #1577350: Bot moving other module's issues to Drupal core issue queue
Comment #23
mathankumarc CreditAttribution: mathankumarc commentedMoving back to Statuses (Social Microblog) issue queue.