I originally reimplemented much of the functionality in the Varnish module in drupalorg_git_varnish because i wanted to pass multiple messages per socket connection, which that module did not support at the time. it now does, according to #1089878: Make it possible to execute more than one command in one connection.. and, given that my logic seems to be buggy and causes some weird counting errors (seems like an OBO type situation), it'd be great to rip out my custom connection logic and just rely on theirs.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | 0001-Issue-1551292-follow-up-Enable-varnish-module-for-dr.patch | 1.18 KB | marvil07 |
| #5 | 0001-Issue-1551292-Interact-with-varnish-via-varnish-modu.patch | 9.63 KB | marvil07 |
Comments
Comment #1
sdboyer commentedand yeah, assigning to me.
Comment #2
drummThis seems like something that would be good to get done so we have less code to bring to D7.
Comment #3
drummgit tag
Comment #4
tvn commentedtag did not stick
Comment #5
marvil07 commentedThis should be working, but I have not yet tested it.
Update: Notice that this patch removes the drupalorg_git_varnish_connection_info variable(which was default to 127.0.0.1:6082), so the varnish control host url information should now live at varnish module settings instead. Basically set varnish_control_terminal(defaults to 127.0.0.1:6082) variable to the right value.
Comment #6
marvil07 commentedI have just tested this on git7site with varnish latest stable release, everything seems to be functioning correctly. I would say to go and add it to upstream.
About the variable,
drupalorg_git_varnish_connection_info, is not defined on settings.php, so it's not in bzr. It is defined only on settings.local.php, and the values are the same as varnish module defaults, so I think we do not need to define any new variable for now unless productions settings.local.php has a value set for thedrupalorg_git_varnish_connection_info, in which case we need to setvarnish_control_terminalvariable.Notice that for deploying this we we'll need also to add varnish module to bzr.
Comment #7
marvil07 commentedOK, added, btw it was the D7 version.
Comment #8
drummPlease also add a
drupalorg_git_varnish_update_N()which doesmodule_enable(array('varnish'))(and double check that syntax).Comment #9
marvil07 commentedThanks for the comment, it's now added.
Patch ftr.