Comments

mathankumarc’s picture

Status: Active » Needs review
StatusFileSize
new3.26 KB

Do we need to change any other places?

icecreamyou’s picture

Status: Needs review » Needs work

A few more places:

./includes/statuses.preprocess.inc:114:      $title = t('@sender: @message', array('@sender' => $sender->name, '@message' => $message));
./includes/statuses.preprocess.inc:122:        array('@sender' => $sender->name, '@recipient' => $recipient_name, '@message' => $message)
./includes/utility/statuses.announce.inc:73:    array('%user' => $to->name, '@current' => $context['sandbox']['progress'], '@total' => $count));
./includes/utility/statuses.announce.inc:75:  $context['results'][] = check_plain($to->name);
./submodules/fbss_notifications/fbss_notifications.module:384:          'name' => t('All status updates by @name', array('@name' => $arg1->name)),
./submodules/fbss_rules/fbss_rules.rules_defaults.inc:32:              'message' => '<?php echo check_plain($account->name); ?> submitted the status <?php echo $new_status; ?>.',
./submodules/fbss_services/fbss_services.extended.inc:256:    'in-reply_to_screen_name' => $status->sender == $status->recipient ? NULL : check_plain(user_load($status->recipient)->name),
./submodules/fbss_services/fbss_services.extended.inc:272:      'name' => isset($account->realname) ? check_plain($account->realname) : check_plain($account->name), # this should just be 'name' => format_username($account)

Thanks

mathankumarc’s picture

Status: Needs work » Needs review
StatusFileSize
new8.01 KB

Here is the modified one.

icecreamyou’s picture

Status: Needs review » Needs work
+++ b/submodules/fbss_services/fbss_services.extended.inc
@@ -269,8 +269,8 @@ function fbss_services_get_rich_data($status, $include_entities = TRUE, $trim_us
+      'screen_name' => check_plain(format_username($account)),

This is an unusual case because this particular function is designed to imitate the Twitter API, where "name" is the formatted name (e.g. Isaac Sukin) and "screen_name" is the actual username (e.g. IceCreamYou). So this line should actually just use $account->name without format_username().

Other than that this is RTBC.

mathankumarc’s picture

Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.