Subtask of #1569988: [Meta] Project issue settings D7 cleanup

The 'Issue directory' setting is bogus. That can now be configured directly as part of the file upload field on issues (see #1551354: Add a file upload field to project issue nodes for more).

So, we need to remove this setting and any places we refer to it from the code.

CommentFileSizeAuthor
#2 project-issue-remove-issue-directory-1571394-2.patch1.27 KBrgristroph

Comments

senpai’s picture

senpai commented
Assigned: Unassigned » rgristroph
Issue tags: +sprint 2

Assigning and tagging.

rgristroph’s picture

rgristroph commented
Status: Active » Needs review
StatusFileSize
new project-issue-remove-issue-directory-1571394-2.patch1.27 KB

This was pretty simple, patch attached. Test by going to admin/project/project-issue-settings ; prior to applying this patch, near the top will be a text field for "Issue directory", and after applying the patch it will be gone.

I checked the rest of the code for any places where the variable might have been used; other than a function to check the directory in includes/admin.settings.inc there were none.

While we are doing settings related changes, should we make the settings page easier to get to ? Right now the link to admin/project/project-issue-settings is not on the modules page in the configuration column but it is at the 2d level of the "Management" block which seems wrong.

--Rob

dww’s picture

dww
we/he/they
commented
Status: Needs review » Fixed
Issue tags: +sprint 4

Thanks, yeah, this was supposed to be a pretty trivial issue. ;) Committed 84ade44 and pushed to 7.x-2.x.

In terms of making the settings page easier to get to, the goal of #1569988: [Meta] Project issue settings D7 cleanup was to actually remove the global settings page entirely. However, there's some chance we'll need some settings to remain, e.g. perhaps #1571398: Port 'Project selection widget' setting (project_issue_autocomplete) will remain a global setting after all. We can deal with that problem at those other issues.

Cheers,
-Derek

Automatically closed -- issue fixed for 2 weeks with no activity.