Removed the scoped .find() an ID is unique on a page and doesn't need to be scoped.
Added the Drupal object to the closure like we're doing with the jQuery object (see #1089300-5: Clean up drupal.js)
removed the closure in .once() instead we check that .once() returned an element and process it.
Changed the name of progress to progressBar to avoid confusion with the new $progress variable.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | 1574490_core-js-selectors-batch-10.patch | 2.12 KB | frega |
| #8 | 1574490-core-js-selectors-batch-8.patch | 2.14 KB | frega |
| #7 | 1574490-core-js-selectors-batch-7.patch | 2.07 KB | frega |
| #6 | core-js-selectors-batch-6.patch | 1.91 KB | nod_ |
| #2 | core-js-selectors-batch-1.patch | 1.91 KB | nod_ |
Comments
Comment #1
nod_Comment #2
nod_Extended the scope of this clean-up a little.
Debug-friendly: turned anonymous function into named functions.
Declared all variables at the top.
reorder some things to make more sense.
This patch removes 3 anonymous function we were not really using.
Comment #3
nod_Comment #4
robloach#2: core-js-selectors-batch-1.patch queued for re-testing.
Comment #6
nod_reroll
Comment #7
frega commentedRerolled patch from #6 to apply and reflect changes introduced in 722f615437d82c175d1135af12a5cde94255e2f1, f047851a7a5ade6be7ae87e899963594675cf5be (20120819).
Comment #8
frega commentedAdded missing second parameter to self invoking function wrapping code. Re-rolled patch.
Comment #9
pivica commentedInstaller progress bar does not work after this patch - its displayed but not updated with progress. Will take a more look.
Comment #10
frega commentedTested with the installation progress bar. Merged holder and $progress variables.
Comment #11
pivica commentedLooks fine now - progress bar works as expected.
Comment #12
webchickCommitted and pushed to 8.x. Thanks!