Changed selector to use select name instead of a class.
took the processing out of the .once() closure.

CommentFileSizeAuthor
#3 core-js-selectors-timezone.patch1.24 KBdroplet
core-js-selectors-timezone.patch1.25 KBnod_

Comments

pounard’s picture

pounard
Primary language French
commented

Are you sure this won't have any side effects, in case some form element had the same name elsewhere? If not that change seems fine.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Issue tags: +js-novice

tag

droplet’s picture

droplet commented
StatusFileSize
new core-js-selectors-timezone.patch1.24 KB

same to #1574620: Selectors clean-up: book, it should use:

    $form['timezone']['timezone']['#attributes'] = array('class' => array('timezone-detect'));
nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Needs review » Reviewed & tested by the community

no brainer & apply.

Thanks.

pounard’s picture

pounard
Primary language French
commented

I think it's RTBC too. I didn't test thought but the code is simple and straightforward.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed 8.x. Thanks.

Automatically closed -- issue fixed for 2 weeks with no activity.

manuel garcia’s picture

manuel garcia commented
Issue summary: View changes
Parent issue: » #1574470: Selectors clean-up