Just installed a fresh copy of Aegir and disabled the "client" feature on myaegirdomain.com/admin/hosting/features this causes the following error to be logged when you try to add a new site (and the page displays a 500 error):

PHP Fatal error: Call to undefined function _hosting_client_site_default() in /var/aegir/hostmaster-6.x-1.8/profiles/hostmaster/modules/hosting/site/hosting_site.form.inc on line 209

CommentFileSizeAuthor
#11 hosting-1585820-11-D7.patch586 bytesgboudrias
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented

Yes, I think the Client feature is very tightly coupled into the entire system despite appearing as a separate 'feature'.

We either need to work out how to de-couple it - but I suspect the work involved might justify going the other way and preventing it from being disabled.

Steven Jones’s picture

Steven Jones CreditAttribution: Steven Jones commented

I'd go for making the dependency explicit in 1.x, and then uncoupling them in 2.x.

Steven Jones’s picture

Steven Jones CreditAttribution: Steven Jones commented
Status: Active » Fixed

I've made the dependency explicit. i think removing the dependency will have to wait.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

anarcat’s picture

anarcat CreditAttribution: anarcat commented
Title: Can't disable the "client" feature » Disabling the client feature yields an error

  • Commit c9c62d1 on 6.x-2.x, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-588728-views-integration, dev-1403208-new_roles, dev-helmo-3.x by Steven Jones: 
    Issue #1585820 by Steven Jones: Fixed Can't disable the 'client" feature...

  • Commit c9c62d1 on 6.x-2.x, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-588728-views-integration, dev-1403208-new_roles, dev-helmo-3.x by Steven Jones: 
    Issue #1585820 by Steven Jones: Fixed Can't disable the 'client" feature...
Pol’s picture

Pol
the/that
Location Brussels
CreditAttribution: Pol commented
Version: 6.x-1.8 » 7.x-3.x-dev
Issue summary: View changes

We can still disable the client module on Aegir 7.x-3.x.

When disabled, all the features gets disabled too.

Pol’s picture

Pol
the/that
Location Brussels
CreditAttribution: Pol commented
Status: Closed (fixed) » Active

  • Steven Jones committed c9c62d1 on 7.x-4.x 
    Issue #1585820 by Steven Jones: Fixed Can't disable the 'client" feature...
gboudrias’s picture

gboudrias CreditAttribution: gboudrias at Praxis Labs Coop commented
Status: Active » Needs review
FileSize
hosting-1585820-11-D7.patch586 bytes

As far as I can tell this is all we're missing.

gboudrias’s picture

gboudrias CreditAttribution: gboudrias at Praxis Labs Coop commented
Issue tags: +Aegir 3.1

Can anyone review this simple patch so we can get this in 3.1?

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
CreditAttribution: ergonlogic commented
Status: Needs review » Reviewed & tested by the community

That should do it.

joestewart’s picture

joestewart CreditAttribution: joestewart commented

Curious, does the sites directory symlink still work after this change?

http://cgit.drupalcode.org/provision/tree/platform/provision_drupal.drus...

gboudrias’s picture

gboudrias CreditAttribution: gboudrias at Praxis Labs Coop commented

Hi Joe, not sure I understand your question, all the patch does is forbid people from disabling the module, so it shouldn't change the functionality at all. Can you elaborate?

joestewart’s picture

joestewart CreditAttribution: joestewart commented

Ha, I misread the patch. I thought the client feature had already become required. And this patch was allowing it to be optional again.

Ignore.

thanks.

gboudrias’s picture

gboudrias CreditAttribution: gboudrias at Praxis Labs Coop commented
Status: Reviewed & tested by the community » Fixed

Forgot the pound sign in the commit, pushed in a0009f235ea8939018d537830a109c56c9eafff0.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.