Professional Share

welcome,

You are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

As installation and usage instructions are quite important for us to review, please take a moment to make your project page follow the tips for a great project page.

• Use indentation with 2 spaces instead of 4 everywhere
• Instead of adding css and js on hook init, add it to your .info so it can be aggregated global (See stylesheets[] and scripts[])
• Please remove the LICENSE.txt file. Drupal.org will add the appropriate version automatically during packaging so your repository should not include it.
• Crate a prefixing comment block /**/ to all functions properly, see doxygen standarts

while waiting for an in-depht review of your module you can start out fixing some coding style issues detected by automated tools:
http://ventral.org/pareview/httpgitdrupalorgsandboxkenmorico1588964git

We do really need more hands in the application queue and highly recommend to get a review bonus so we can come back to your application sooner.

regards

I'm not sure how this module is really that different from an existing one like Service Links . I think it might be better for you to contribute to that project rather than start up a very similar new project (for example, adding the analytics).

That being said, I do have some comments after reviewing the module:

1) You ask that the Twitter username not contain the @ symbol, but you never validate the form contents to ensure it's not there, nor do you do any error checking when you pull the configuration variable. You should add a form_validate() step to ensure the stored values are what you're expecting.

2) You ask for an Admin Facebook User ID and App IDs, but you don't give any instruction on how someone is supposed to find this information.

3) I would add configuration options into the block configuration to enable/disable each of the sharing options (Facebook, Twitter, LinkedIn, and G+). This gives the user a little more control over where their page can be shared.

4) Why 3 blocks? I can't imagine needing this to appear in more than one place on a page.

5) Overall, this module needs better UI documentation.

Closing due to lack of activity. Feel free to reopen if you are still working on this application.