Part of meta-issue #1788918: [GTD] [META] Prepare for Twig main engine core inclusion until December 1

We will see how we will integrate with it. But first, let's add it so that the integration patches are reviewable.

CommentFileSizeAuthor
#14 Add-Twig-to-COPYRIGHT.txt-and-copy-AUTHORS.patch3.17 KBgreg.1.anderson
#13 0001-Add-Twig-to-COPYRIGHT.txt-and-copy-Twig-LICENSE-to-c.patch2.47 KBgreg.1.anderson
#9 1591686.patch384.48 KBRobLoach
#8 twig.patch384.19 KBRobLoach
twig.patch379.46 KBchx
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented

I don't wonna be a dick but does twig has a signoff from everyone (including Dries?)

bojanz’s picture

bojanz CreditAttribution: bojanz commented

As much as the Symfony stuff did when it was committed.

That said, committing huge chunks of external code like this makes me sad -> we need Composer.

chx’s picture

chx CreditAttribution: chx commented

I have yet to find any dissent in #1499460: [meta] New theme system and yeah much like Symfony if it is not working out then we can rip it out but I really would prefer not to submit 300K+ patches when we actually try to use this.

Crell’s picture

Crell CreditAttribution: Crell commented

+1 on this issue for now.

+1 for following up with #1424924: Use Composer for updating Symfony components (without removing Symfony code from repo)

+1 for then switching to pure-composer later.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Assigned: Unassigned » Dries

This is fine with me, but I've never actually seen Dries weigh in on Twig yet, so over to him.

chx’s picture

chx CreditAttribution: chx commented

Writeups: http://groups.drupal.org/node/234793 http://groups.drupal.org/node/234838

jenlampton’s picture

jenlampton
she / her
CreditAttribution: jenlampton commented

For reference: http://groups.drupal.org/node/234793 and http://groups.drupal.org/node/234838

edit: chx is faster than I am :/

RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented
Status: Reviewed & tested by the community » Needs review
FileSize
twig.patch384.19 KB
  • Updated to dev-master (drush composer create-project twig/twig)
  • Added Twig to our PSR-0 class-loader
RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented
FileSize
1591686.patch384.48 KB

chx brought up a good point that we need to use PEAR-style autoloading for this, which is "Prefixes" in Symfony's autoloader.

chx’s picture

chx CreditAttribution: chx commented
Status: Needs review » Reviewed & tested by the community
Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Alright, folks. I committed this to 8.x to encourage all of us to make progress on this initiative. If the theme system revamp doesn't come to fruition, we will roll this back. Looking forward to the "real" follow-up patches. Ready, set, go! :-)

Dries’s picture

Dries CreditAttribution: Dries commented
Assigned: Dries » Unassigned

No longer needs to assigned to me.

greg.1.anderson’s picture

greg.1.anderson CreditAttribution: greg.1.anderson commented
Title: Add Twig itself » Twig copyright missing from COPYRIGHT.txt
Status: Fixed » Needs review
FileSize
0001-Add-Twig-to-COPYRIGHT.txt-and-copy-Twig-LICENSE-to-c.patch2.47 KB

To comply with core/vendor/README.txt, COPYRIGHT.txt should contain the copyright to twig. To comply with the Twig license, the file LICENSE should also be included in the core/vendor/Twig directory.

greg.1.anderson’s picture

greg.1.anderson CreditAttribution: greg.1.anderson commented
FileSize
Add-Twig-to-COPYRIGHT.txt-and-copy-AUTHORS.patch3.17 KB

We should probably also have AUTHORS, since LICENSE references it.

chx’s picture

chx CreditAttribution: chx commented
Status: Needs review » Reviewed & tested by the community

Thanks!

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Reviewed & tested by the community » Fixed

I committed the patch in #14 to 8.x.

chx’s picture

chx CreditAttribution: chx commented
Title: Twig copyright missing from COPYRIGHT.txt » Add Twig itself

Titling back and thanks for the emergency commit.

RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented

Thanks Greg! Not sure where those went in my patch :-) .

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
CreditAttribution: podarok commented
Issue summary: View changes

Updated issue summary.