This module adds things to documentation pages.

CommentFileSizeAuthor
#3 1599068-v2.patch12.25 KBjhodgdon
#2 1599068-v1.patch12.23 KBjhodgdon

Comments

jhodgdon’s picture

Assigned: Unassigned » jhodgdon

I am working on this at the Portland sprint today! Starting at the top of the module, I'm just working through the code and making sure each function does what it is supposed to be doing (by comparing with what it does on drupal.org vs. the D7 dev site). I'll probably just file a patch at the end of the day...

jhodgdon’s picture

Status: Active » Needs review
StatusFileSize
new12.23 KB

I have a preliminary patch! (after uploading I will test it and report back)

I think this fixes everything in the drupalorg_handbook module, with the following exceptions and notes:

a) On the dev site I am using, there's a problem in the theme displaying comments at all, so I didn't do anything to the drupalorg_handbook_form_comment_form_alter() function.

b) node/263594 (handbook revisions) - this page is unpublished on drupal.org, so it doesn't get transferred to dev sites. So to test that this is working, you have to make a temporary page and substitute its node ID on this line in drupalorg_handbook_node_view():

      case 263594: // Revision maintainers
        $extra = drupalorg_handbook_revision_maintainers();
        break;
 

c) There was some weird problem with the visibility of the License block in drupalorg_handbook. The block wouldn't show until we went into the Blocks config page, set the visibility to "only the listed", saved, then
went back in and set it back to "everything but the listed" pages.

d) There are some other handbook theming problems on the test site I was working on:

1. node/13355 - Has an OL list that is not showing the numbers (list-style: none) - looks like a CSS issue. (Any OL should have a similar problem).

2. Documentation sidebar formatting is not working (colors on page status, indentation on the taxonomy stuff).

jhodgdon’s picture

StatusFileSize
new12.25 KB

That patch was OK except for one line; here's a new patch.

jhodgdon’s picture

I filed a follow-up issue #1683804: Test and/or update handbook function for comment form alter for the one part of drupalorg_handbook that hasn't been updated/tested yet.

drumm’s picture

Status: Needs review » Fixed

Committed.

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit a2c91d3 on 7.x-3.x, 7.x-3.x-dev authored by jhodgdon, committed by drumm:
    [#1599068] Ensure drupalorg_handbook works well on D7